fix(deps): consume tinyinference and tinymemory-api by git rev, not nested submodules by senamakel · Pull Request #182 · tinyhumansai/tinycortex

senamakel · 2026-10-01T18:51:13Z

Nested path submodules (#176) cannot be overridden by a host [patch] table, so tinymemory (owner of tinymemory-api, with its own tinyinference) got duplicate crates / lockfile package collision when bumping vendor/tinycortex. Restores git dependencies (revs = the previously vendored submodule pins: tinyinference 92445ea, tinymemory 1a03a00; the old 4549cda tinymemory pin lacks DataSource::Upload/WebPage) and drops the submodules/workspace members. Verified: clippy -D warnings + tests here, and clippy + tests in tinymemory with vendor/tinycortex bumped to this branch.

Summary by CodeRabbit

Chores
- Updated project workspace configuration so standard Cargo commands include the API crate. No changes to application features or user-facing behavior are included.

…ested submodules Nested path submodules cannot be overridden by a host [patch] table, so a host that owns tinymemory-api/tinyinference (tinymemory) got duplicate crates in its lockfile. Git dependencies let the host's [patch."<git url>"] tables collapse them onto its own checkouts. Revs match the previously vendored submodule pins. Co-authored-by: Medulla <medulla@tinyhumans.ai>

tinysweeper · 2026-10-01T18:51:17Z

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Incomplete
Priority: none
Reviewed head: 102934d3bfa3
Updated: 1790880706 (Unix time)

Review snapshot

Change surface	Files	Review signal	Count
Production	1	Active findings	0
Tests	0	Noted findings	0
Documentation	0	Resolved findings	0
Configuration	2	Pending checks/questions	5

Completeness: Incomplete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Could not review: Cargo.toml, api/Cargo.toml, tinysweeper/description

Before merge

Complete the critique review for Cargo.toml, api/Cargo.toml.
Complete the security review for Cargo.toml, api/Cargo.toml.
Complete the description review for tinysweeper/description.

Agent review details

critique

Conclusion: Neutral
Scope reviewed: incomplete; unanswered: Cargo.toml, api/Cargo.toml
Lane summary: Reviewed 0 files; 0 findings. 2 files could not be reviewed: Cargo.toml, api/Cargo.toml.

security

Conclusion: Neutral
Scope reviewed: incomplete; unanswered: Cargo.toml, api/Cargo.toml
Lane summary: Reviewed 0 files; 0 findings. 2 files could not be reviewed: Cargo.toml, api/Cargo.toml.

tests

Conclusion: Neutral
Scope reviewed: all assigned evidence
Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

Conclusion: Neutral
Scope reviewed: all assigned evidence
Lane summary: Nothing sensitive found in what this pull request commits.

description

Conclusion: Neutral
Scope reviewed: incomplete; unanswered: tinysweeper/description
Lane summary: No reviewer could be consulted.

e2e

Conclusion: Neutral
Scope reviewed: all assigned evidence
Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

Evidence and run details

Models: ladder/vectors
Spend: $0.000004
Tokens: 0 input · 0 output · 0 cached · 440 embedding

Head	State	Pass summary
`102934d3bfa3`	incomplete	0 active finding(s), 0 resolved finding(s) (at 1790880706)

chatgpt-codex-connector · 2026-10-01T18:51:22Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-01T18:53:30.672026Z	`102934d`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-01T18:51:30Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 60150899-2f25-440e-8267-bde6b36030b2

📥 Commits

Reviewing files that changed from the base of the PR and between 9bbabd7 and 102934d.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (5)

.gitmodules
Cargo.toml
api/Cargo.toml
vendor/tinyinference
vendor/tinymemory

💤 Files with no reviewable changes (3)

.gitmodules
vendor/tinyinference
vendor/tinymemory

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The workspace now includes the root crate and api, and excludes vendor/. The TinyInference and TinyMemory submodule references are removed. Their dependencies now use pinned Git revisions.

Changes

Cargo dependency sources

Layer / File(s)	Summary
Workspace membership and vendor cleanup `.gitmodules`, `Cargo.toml`, `vendor/tinyinference`, `vendor/tinymemory`	The workspace includes the root crate and `api`, excludes `vendor/`, and removes the TinyInference and TinyMemory submodule references.
Pinned Git dependencies `Cargo.toml`, `api/Cargo.toml`	The TinyInference and TinyMemory dependencies now use Git repositories pinned to fixed revisions. Comments describe the pins and host patching for shared contract types.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 10293

This change moves two dependencies from vendored submodules to pinned Git revisions, which lets host projects patch them with their own checkouts. The pins match the lockfile, and no concrete risk was found. It is ready to merge under normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 10293

The change affects 2 systems.

Changed systems: api, Cargo.toml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — api (service) was modified; 1 changed file maps to changed impact.
observed — Cargo.toml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in Cargo.toml: The workspace removes the vendored TinyInference and TinyMemory crates from members, replaces the expanded member list with [".", "api"], and excludes vendor/. The default members remain [".", "api"]; comments now describe workspace coverage and default command behavior.
observed — Modified behavior in Cargo.toml: The TinyInference embedding and LLM dependencies switch from local vendor paths to Git dependencies pinned to revision 92445ea582c9b1c5dc78891ebbff4a817f9e8fa9; the comments now describe the shared trait identity and host patching.
observed — Modified behavior in api/Cargo.toml: The dependency changes from the vendored path to the TinyMemory Git repository pinned to revision 1a03a00c11f68beea63a743bb369d947f98fcde1. The added comments document the pinning and the Git-URL patch required when a host vendors both crates to keep their contract types unified.
observed — Modified behavior in .gitmodules: The .gitmodules file was removed, including the vendor/tinyinference and vendor/tinymemory submodule paths, repository URLs, and main branch declarations.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: replacing nested submodules with Git dependencies pinned to revisions for tinyinference and tinymemory-api.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

_{A rabbit checks the crates at dawn,
The vendor paths have now withdrawn.
Two pinned revisions mark the trail,
The workspace lists its crates in scale.
I hop through Cargo, neat and bright,
Then nibble clover by moonlight.}

_{Comment @coderabbitai help to get the list of available commands.}

tinysweeper

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: Cargo.toml, api/Cargo.toml, tinysweeper/description.

$0.0000 · 0 in / 0 out · 440 embedded · ladder/vectors

tinysweeper Bot reviewed Oct 1, 2026

View reviewed changes

tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 1, 2026

coderabbitai Bot approved these changes Oct 1, 2026

View reviewed changes

senamakel merged commit cdc07b8 into main Oct 1, 2026
15 checks passed

Navigation Menu

Repository navigation

fix(deps): consume tinyinference and tinymemory-api by git rev, not nested submodules - #182

fix(deps): consume tinyinference and tinymemory-api by git rev, not nested submodules#182
senamakel merged 1 commit into
mainfrom
fix-git-deps

senamakel commented Oct 1, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

tinysweeper Bot commented Oct 1, 2026 •

edited

Loading

critique

security

tests

commits

description

e2e

Uh oh!

chatgpt-codex-connector Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

tinysweeper Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

senamakel commented Oct 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

tinysweeper Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tiny Sweeper review

Review snapshot

What changed

Features

Tests

Findings

Before merge

critique

security

tests

commits

description

e2e

Uh oh!

chatgpt-codex-connector Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

tinysweeper Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

senamakel commented Oct 1, 2026 •

edited by coderabbitai Bot

Loading

tinysweeper Bot commented Oct 1, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 1, 2026 •

edited

Loading

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading