Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
senamakel
pushed a commit
that referenced
this pull request
Sep 28, 2026
tinybus 6ee8258..e5f1cd2 (#25-#29): Windows module load and file-ACL fixes, plus additive static/linked-module support (LinkedModule, start_linked_module, a static-link feature). No public item removed. tinyjevclient 84b3983..19ad7b1 (#7, #8): exact endpoint overrides and host-product attribution on Jev requests. Cargo.lock is unchanged: no crate version or dependency set moved. Refs tinyhumansai/openhuman#6750
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
static-link(withlinkedas an alias) and usesmodule_export_optional_static!to select the Rust-addressable module export. The normal build keeps its dynamic C ABI. TinyJevClient and TinyBus use exact version dependencies with local workspace patches. The nested TinyBus checkout is pinned to commit433d9edfrom tinyhumansai/tinybus#29.Draft readiness condition: TinyBus PR #29 must merge, then this repository must pin its merged commit and pass CI before this PR is marked ready or merged.
Related issue
None.
API or behavior changes
With
static-link, Rust hosts can calltinybrowser::linked_module()to register this module in process.linkedremains an alias forstatic-link.Validation
cargo check -p tinybrowser --lockedcargo check -p tinybrowser --features static-link --lockedcargo fmt --all -- --checkgit diff --checkTests
TinyBus PR #29 covers the shared module export behavior. Full repository suites were not run locally.
Documentation
The crate-root function has rustdoc; the TinyBus dependency PR documents the host registration API.
Checklist
#[ignore]or relaxed lint settings