Skip to content

test: cover greeting to Gmail tool continuation - #6659

Merged
senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:transcript-hi-e2e-live
Sep 25, 2026
Merged

senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:transcript-hi-e2e-live

Conversation

@senamakel

@senamakel senamakel commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Pin TinyAgents with a full agent-loop regression for “Hi” followed by a deferred Gmail fetch.
  • Keep the active request and search result in one outgoing prompt turn.
  • Record a reproducible live validation boundary for the managed DeepSeek route.

Problem

The previous prompt patch passed focused tests but live DeepSeek V4 Flash still sometimes answered the earlier greeting after receiving the later email request. A separate trailing user message also made it repeat tool_search despite receiving a Gmail match.

Solution

TinyInference #30 combines the active request and tool result in one prompt turn. TinyAgents #218 adds the end-to-end test and pins that correction. This OpenHuman PR pins TinyAgents. The managed DeepSeek route still needs a production routing/model decision, so this PR remains a draft.

Submission Checklist

  • Tests added or updated — the TinyAgents end-to-end test covers greeting, search, deferred Gmail execution and answer.
  • Diff coverage ≥ 80% — N/A: only a gitlink changes here; upstream CI owns source coverage.
  • Coverage matrix updated — N/A: no feature row changed.
  • All affected feature IDs listed under Related — N/A: no feature row changed.
  • No new external network dependencies introduced.
  • Manual smoke checklist updated — N/A: no release-cut surface changed.
  • Linked issue closed — N/A: no linked issue.

Impact

Agent turns using a text tool dialect keep the current request and returned tool result together. No persistent transcript rows change. Live model reliability remains dependent on the managed provider route.

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: transcript-hi-e2e-live
  • Commit SHA: dc9af70

Validation Run

  • pnpm --filter openhuman-app format:check — N/A: no app changes.
  • pnpm typecheck — N/A: no TypeScript changes.
  • Focused tests: TinyInference prompt tests 17 passed; TinyAgents dialect tests 6 passed; TinyAgents tool-dialect E2E tests 23 passed.
  • Rust fmt/check (if changed): upstream Rust workspaces formatted; patched OpenHuman CLI binary built.
  • Tauri fmt/check (if changed) — N/A: no Tauri changes.

Validation Blocked

  • command: Live Hi → fetch my latest email via openhuman.agent_chat on the default DeepSeek V4 Flash route.
  • error: The backend received the complete latest user request but intermittently replied with the earlier greeting; the Gmail tool was not consistently called.
  • impact: Do not treat this pin as a complete production fix until the managed model/routing issue is resolved.

Behavior Changes

  • Intended behavior change: keep current request and discovered tool result in one provider prompt turn.
  • User-visible effect: avoid restarting discovery after a successful tool search; live DeepSeek behavior remains unresolved.

Parity Contract

  • Legacy behavior preserved: durable transcript and native tool messages unchanged.
  • Guard/fallback/dispatch parity checks: E2E covers the deferred bridge and final tool execution.

Duplicate / Superseded PR Handling

  • Duplicate PR(s): N/A
  • Canonical PR: this PR
  • Resolution (closed/superseded/updated): N/A

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1d3b75c0-08d5-4583-95b4-de1c3bc3f9bc

📥 Commits

Reviewing files that changed from the base of the PR and between 63b8c76 and dc9af70.

📒 Files selected for processing (1)
  • vendor/tinyagents
 _______________________________________________
< Now streaming live: defusing your code bombs. >
 -----------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel marked this pull request as ready for review September 25, 2026 12:49
@senamakel
senamakel requested a review from a team September 25, 2026 12:49
@tinysweeper

tinysweeper Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: dc9af70ca04a
Updated: 1790340663 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

security

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No added or modified lines to review.
Evidence and run details
  • Models: ladder/vectors
  • Spend: $0.000000
  • Tokens: 0 input · 0 output · 0 cached · 13 embedding
Head State Pass summary
dc9af70ca04a ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1790340663)

tinysweeper 0.1.0

@senamakel
senamakel merged commit dc96421 into tinyhumansai:main Sep 25, 2026
28 of 35 checks passed

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

$0.0000 · 0 in / 0 out · 13 embedded · ladder/vectors

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant