Repository navigation
Wait for effects in zulip addressing routing test - #128
Merged
Merged
Conversation
The test asserted on handled turns and log.jsonl 60ms after each POST, but handling continues after the 202 response, so under load it intermittently saw too few turns or a partially written log. Poll (up to 2s) for the expected turn count and log row before asserting; negative assertions keep the fixed delay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alosec
force-pushed
the
riker/zulip-routing-test-wait
branch
from
November 16, 2026 10:54
bd669d1 to
8e5b9cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/zulip-addressing-routing.test.tswas flaky (about 2 in 5 runs failed in isolation on a dev Mac): it asserted 60ms after each POST, but the adapter keeps handling after returning 202.handledcount.log.jsonlread in step 1 waits for its row instead of parsing a possibly partial file.Test-only. Before: 3/5 passes in isolation. After: 12/12 serial and 32/32 with 8 concurrent copies.
🤖 Generated with Claude Code