Skip to content

Wait for effects in zulip addressing routing test - #128

Merged
alosec merged 1 commit into
mainfrom
riker/zulip-routing-test-wait
Nov 16, 2026
Merged

alosec merged 1 commit into
mainfrom
riker/zulip-routing-test-wait

Conversation

@alosec

@alosec alosec commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

test/zulip-addressing-routing.test.ts was flaky (about 2 in 5 runs failed in isolation on a dev Mac): it asserted 60ms after each POST, but the adapter keeps handling after returning 202.

  • Positive assertions (a turn is taken) now poll up to 2s for the expected handled count.
  • The log.jsonl read in step 1 waits for its row instead of parsing a possibly partial file.
  • Negative assertions (no turn) keep the fixed delay.

Test-only. Before: 3/5 passes in isolation. After: 12/12 serial and 32/32 with 8 concurrent copies.

🤖 Generated with Claude Code

The test asserted on handled turns and log.jsonl 60ms after each POST, but
handling continues after the 202 response, so under load it intermittently
saw too few turns or a partially written log. Poll (up to 2s) for the
expected turn count and log row before asserting; negative assertions keep
the fixed delay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alosec
alosec force-pushed the riker/zulip-routing-test-wait branch from bd669d1 to 8e5b9cd Compare November 16, 2026 10:54
@alosec
alosec merged commit 8e21e8b into main Nov 16, 2026
3 checks passed
@alosec
alosec deleted the riker/zulip-routing-test-wait branch November 16, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant