Skip to content

Add pnpm test: run every test file, report all failures - #124

Merged
alosec merged 1 commit into
mainfrom
riker/test-runner
Nov 16, 2026
Merged

alosec merged 1 commit into
mainfrom
riker/test-runner

Conversation

@alosec

@alosec alosec commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

What

  • pnpm test → scripts/run-tests.mjs: discovers every test/*.test.{ts,mjs}, hostd/test/*.test.mjs and ui/test/*.test.tsx file (209 today), runs them in parallel (default concurrency min(8, cores-1), -j/TEST_CONCURRENCY), with a per-file timeout (default 180s, kills the whole process group). Every file runs; failures' output and a summary are printed at the end and the exit code is nonzero if anything failed.
  • Select by substring (pnpm test slack voice), --exclude <substring>, --list, --verbose, --help.
  • .ts files run with tsx (tsx --test when they use node:test), .mjs with node --test. Files in a package with its own tsconfig.json (ui/) get --tsconfig so JSX compiles — ui/test/web-ui-steering-render.test.tsx was not run by any script before and passes this way.
  • Existing test:* scripts and validate:local are unchanged.
  • New Tests workflow (PRs + pushes to main): install, typecheck, build, pnpm test on Node 22/Linux, excluding macos-resident-updater (needs PlistBuddy) and tui-pty (expect-driven, fails headless). Previously CI only ran public-safety and the package-manager contract.
  • README Development section documents it.

Results

Local (macOS, Node 26): 204/209 on main before; remaining failures are pre-existing and fail serially too: tui-pty (headless), teams-config and hostd/test/scheduled-wakes (pass on Linux/Node 22 CI, fail locally on Node 26), voice-contract (fixed by #125). zulip-addressing-routing is flaky in isolation (~2/5 runs fail on main).

Full run is ~85s on CI vs. the serial chain.

🤖 Generated with Claude Code

scripts/run-tests.mjs discovers test/*.test.{ts,mjs}, hostd/test/*.test.mjs
and ui/test/*.test.tsx, runs them in parallel with a concurrency limit and a
per-file timeout, and prints every failure's output and a summary at the end
instead of stopping at the first failure. Files can be selected by substring
or excluded; --list prints the set. The per-area test:* scripts are unchanged.

Add a Tests workflow that typechecks, builds and runs the full suite on Linux
(excluding the macOS-only updater test and the expect-driven PTY test).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alosec
alosec marked this pull request as ready for review November 16, 2026 10:36
@alosec
alosec merged commit f070199 into main Nov 16, 2026
3 checks passed
@alosec
alosec deleted the riker/test-runner branch November 16, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant