Skip to content

Geometry query contains mode for both filter directions #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasbindreiter merged 1 commit into from
Sep 4, 2026
Merged

Geometry query contains mode for both filter directions #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apis/datasets/v1/data_access.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,10 @@
SPATIAL_FILTER_MODE_UNSPECIFIED = 0;
// Any geometry that intersects the filter geometry is included.
SPATIAL_FILTER_MODE_INTERSECTS = 1;
// Only geometries fully contained within the filter geometry are included.
SPATIAL_FILTER_MODE_CONTAINS = 2;
// Only datapoint geometries fully contained within the filter geometry are included.
SPATIAL_FILTER_MODE_FILTER_CONTAINS_GEOMETRY = 2;

Check failure on line 186 in apis/datasets/v1/data_access.proto

View workflow job for this annotation

GitHub Actions / Buf 

Enum value "2" on enum "SpatialFilterMode" changed name from "SPATIAL_FILTER_MODE_CONTAINS" to "SPATIAL_FILTER_MODE_FILTER_CONTAINS_GEOMETRY".
// Only datapoint geometries that fully contain the filter geometry are included.
SPATIAL_FILTER_MODE_GEOMETRY_CONTAINS_FILTER = 3;
}

// SpatialCoordinateSystem specifies the coordinate system in which to perform geometry calculations such as
Expand All @@ -201,7 +203,7 @@
message SpatialFilter {
// The geometry to filter by.
Geometry geometry = 1 [(buf.validate.field).required = true];
// Whether to filter by intersection or containment.
// How to compare datapoint geometries with the filter geometry.
SpatialFilterMode mode = 2 [(buf.validate.field).enum.defined_only = true];
// Coordinate system in which to perform geometry calculations.
SpatialCoordinateSystem coordinate_system = 3 [(buf.validate.field).enum.defined_only = true];
Expand Down
Loading