Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apis/accounts/v1alpha1/account.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
package accounts.v1alpha1;

import "buf/validate/validate.proto";
import "tilebox/v1/id.proto";

option features.field_presence = IMPLICIT;

Expand All @@ -20,9 +21,9 @@
// The authentication method used to authenticate the request.
AuthenticationMethod active_authentication_method = 5;
// The canonical Tilebox user ID.
string user_id = 6 [(buf.validate.field).string.uuid = true];
tilebox.v1.ID user_id = 6;

Check failure on line 24 in apis/accounts/v1alpha1/account.proto

View workflow job for this annotation

GitHub Actions / Buf

Field "6" with name "user_id" on message "AccountDetails" changed type from "string" to "message". See https://developers.google.com/protocol-buffers/docs/proto3#updating for wire compatibility rules and https://developers.google.com/protocol-buffers/docs/proto3#json for JSON compatibility rules.
// The canonical Tilebox organization ID.
string organization_id = 7 [(buf.validate.field).string.uuid = true];
tilebox.v1.ID organization_id = 7;

Check failure on line 26 in apis/accounts/v1alpha1/account.proto

View workflow job for this annotation

GitHub Actions / Buf

Field "7" with name "organization_id" on message "AccountDetails" changed type from "string" to "message". See https://developers.google.com/protocol-buffers/docs/proto3#updating for wire compatibility rules and https://developers.google.com/protocol-buffers/docs/proto3#json for JSON compatibility rules.
}

// AuthenticationMethod describes the credential used to authenticate the request.
Expand Down
24 changes: 1 addition & 23 deletions apis/datasets/v1/datasets.proto
Original file line number Diff line number Diff line change
Expand Up @@ -82,25 +82,6 @@
(buf.validate.field).string.max_len = 1000000
];
}

// ClientInfo contains information about the client requesting datasets, useful for us to gather usage data
message ClientInfo {
// name of the client, e.g. "python"
string name = 1;
// environment the client is running in, e.g. "JupyterLab using python 3.11.4"
string environment = 2;
// list of packages installed on the client
repeated Package packages = 3;
}

// Package contains information about the installed version of a given package on the client
message Package {
// package name
string name = 1;
// package version
string version = 2;
}

// DeleteDatasetRequest is used to delete a dataset
message DeleteDatasetRequest {
// id of the dataset to delete.
Expand All @@ -114,10 +95,7 @@
}

// ListDatasetsRequest is used to request a list of datasets
message ListDatasetsRequest {
// some information about the Tilebox client requesting the datasets
ClientInfo client_info = 1;
}
message ListDatasetsRequest {}

Check failure on line 98 in apis/datasets/v1/datasets.proto

View workflow job for this annotation

GitHub Actions / Buf

Previously present field "1" with name "client_info" on message "ListDatasetsRequest" was deleted without reserving the number "1".

Check failure on line 98 in apis/datasets/v1/datasets.proto

View workflow job for this annotation

GitHub Actions / Buf

Previously present field "1" with name "client_info" on message "ListDatasetsRequest" was deleted without reserving the name "client_info".

// A list of datasets and dataset groups
message ListDatasetsResponse {
Expand Down
Loading