fix: exit 1 for unknown top-level verb instead of 0 - #21
Merged
Merged
Conversation
Unknown verbs (e.g. 'adlc-cli factory-mission') currently print help and exit 0. Callers checking the exit code see success for a command that did nothing. Fix: return 1 in the top-level default case, consistent with how sub-commands (skills/team/workspace/workflow) handle unknown subcommands (print error + help, return 1).
Contributor
Author
|
叉一下～ This makes the exit code consistent with how sub-commands handle unknown arguments (exit 1). Happy to address any feedback! |
kanfil
approved these changes
Sep 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: exit 1 for unknown top-level verb
Unknown top-level verbs (e.g.
adlc-cli factory-mission) currently print help and exit 0. This is problematic because callers checking the exit code see success for a command that did nothing.Changes
In
src/dispatch.mjs, split the top-leveldefaultcase fromcase "help":so that:adlc-cli help→ prints help, exits 0 (unchanged)adlc-cli <unknown-verb>→ prints help, exits 1 (fixed)This is consistent with how sub-commands (
skills,team,workspace,workflow) already handle unknown subcommands: print help + exit 1.References