Skip to content

DOCS-3086: Fix inaccuracies on the GlobalNetworkSet reference - #3122

Draft
ctauchen wants to merge 4 commits into
tigera:mainfrom
ctauchen:DOCS-3086-fact-check-globalnetworkset
Draft

ctauchen wants to merge 4 commits into
tigera:mainfrom
ctauchen:DOCS-3086-fact-check-globalnetworkset

Conversation

@ctauchen

@ctauchen ctauchen commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes inaccuracies on the GlobalNetworkSet reference page, found and verified with the calico-fact-check skill.

  • A global network policy rule includes global network sets only when it has no namespaceSelector, or one that includes global(). With all() or a namespace label expression the set is left out.
  • name: the accepted values listed - twice. The second is a dot.
  • labels: the labels belong to the network set, not an endpoint.

Changes next, 3.33, 3.32 and 3.31. Each fix was reproduced on a kind cluster running that tree's release: v3.33.0 for next and 3.33, v3.32.2 for 3.32, v3.31.7 for 3.31.

Not changed, for follow-up:

  • nets also accepts bare IP addresses, rejects duplicates, and in 3.33 is limited to 100000 entries of at most 49 characters.
  • Labels cannot use the projectcalico.org/namespace key.
  • The kube-proxy SNAT note was not settled.

Previous attempt: #3092.

Preview the changed page:

Copilot AI lite review requested due to automatic review settings October 16, 2026 11:56
@netlify

netlify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 75cb2aa
🔍 Latest deploy log https://app.netlify.com/projects/tigera/deploys/6ad21108e2ce610eb735f740
😎 Deploy Preview https://deploy-preview-3122--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🔴 down 3 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only minor, non-blocking wording nits remain.

0 open findings

What changed in this PR

Updates GlobalNetworkSet reference documentation across current Calico and versions 3.31–3.33.

Changes:

  • Clarifies selector behavior.
  • Corrects accepted name characters.
  • Clarifies label ownership.
File Summary
calico/​reference/​resources/​globalnetworkset.mdx Updated current documentation.
calico_versioned_docs/​version-3.33/​reference/​resources/​globalnetworkset.mdx Updated 3.33 documentation.
calico_versioned_docs/​version-3.32/​reference/​resources/​globalnetworkset.mdx Updated 3.32 documentation.
calico_versioned_docs/​version-3.31/​reference/​resources/​globalnetworkset.mdx Updated 3.31 documentation.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@netlify

netlify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 75cb2aa
🔍 Latest deploy log https://app.netlify.com/projects/calico-docs-preview-next/deploys/6ad2110821cd5b55e9b1f469
😎 Deploy Preview https://deploy-preview-3122--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants