Repository navigation
DOCS-3092: Fix inaccuracies on the NetworkSet reference - #3121
Merged
Merged
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Shared entity-rule documentation still contradicts the updated NetworkSet guidance.
0 open findings
What changed in this PR
Updates NetworkSet references for current Calico and versions 3.31–3.33.
Changes:
- Clarifies policy matching scope.
- Corrects valid name characters.
- Clarifies label ownership.
| File | Summary |
|---|---|
calico/reference/resources/networkset.mdx |
Updated current NetworkSet reference. |
calico_versioned_docs/version-3.33/reference/resources/networkset.mdx |
Updated 3.33 reference. |
calico_versioned_docs/version-3.32/reference/resources/networkset.mdx |
Updated 3.32 reference. |
calico_versioned_docs/version-3.31/reference/resources/networkset.mdx |
Updated 3.31 reference. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ctauchen
marked this pull request as ready for review
October 19, 2026 14:20
Collaborator
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inaccuracies on the NetworkSet reference page, found and verified with the calico-fact-check skill.
Changes next, 3.33, 3.32 and 3.31. Each fix was reproduced on a kind cluster running that tree's release: v3.33.0 for next and 3.33, v3.32.2 for 3.32, v3.31.7 for 3.31.
Not changed, for follow-up:
Previous attempt: #3091.
Preview the changed page:
Next and 3.33 were verified in both API server mode and native v3 CRD mode.