Skip to content

DOCS-3085: Fix inaccuracies on the GlobalNetworkPolicy reference - #3115

Merged
ctauchen merged 7 commits into
tigera:mainfrom
ctauchen:DOCS-3085-fact-check-globalnetworkpolicy
Oct 19, 2026
Merged

ctauchen merged 7 commits into
tigera:mainfrom
ctauchen:DOCS-3085-fact-check-globalnetworkpolicy

Conversation

@ctauchen

@ctauchen ctauchen commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes statements on the GlobalNetworkPolicy reference that a test cluster showed to be wrong.

Jira: https://tigera.atlassian.net/browse/DOCS-3085

  • The name rule allowed _ and uppercase. The validator rejects both and allows at most one ..
  • The Spec table had no tier field. It now lists tier, and order is said to apply within the policy's tier.
  • namespaceSelector and serviceAccountSelector listed all() as the default. An explicit all() excludes host endpoints, so it is not the same as omitting the field.
  • The page said a doNotTrack or preDNAT policy is enforced after conntrack on workload endpoints. Such a policy is not applied to workload endpoints at all.
  • The shared Rule table did not mark action as required. This also fixes the NetworkPolicy and staged policy pages.
  • 3.31 only: a policy outside the default tier must be named <tier>.<name>.

Changes next, 3.33 and 3.32, reproduced on v3.33.0 and v3.32.2, and 3.31, reproduced on v3.31.7.

  • In next and 3.33, the name rule now says to use at most one ., because calicoctl rejects more. With native v3 CRDs, kubectl accepts names with more dots.
  • In next and 3.33, the types footnote says to leave out an empty ingress or egress list. With native v3 CRDs, kubectl counts ingress: [] as rules present, which can deny all ingress.

Next and 3.33 were verified in both API server mode and native v3 CRD mode.

Not changed:

Preview:

Copilot AI lite review requested due to automatic review settings October 16, 2026 07:23
@netlify

netlify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit f67d823
🔍 Latest deploy log https://app.netlify.com/projects/calico-docs-preview-next/deploys/6ad6400b89ce4fbca93995fc
😎 Deploy Preview https://deploy-preview-3115--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit f67d823
🔍 Latest deploy log https://app.netlify.com/projects/tigera/deploys/6ad6400b7e1bd38f94f6af8e
😎 Deploy Preview https://deploy-preview-3115--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🔴 down 1 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

0 open findings

What changed in this PR

Updates GlobalNetworkPolicy documentation to match validated behavior across current and Calico 3.31–3.33 references.

Changes:

  • Corrects naming, tier ordering, selector defaults, and endpoint enforcement details.
  • Marks action as required in shared rule tables.
File Description
calico/​reference/​resources/​globalnetworkpolicy.mdx Updates the current GlobalNetworkPolicy reference.
calico/​_includes/​content/​_rule.mdx Marks rule actions as required.
calico_versioned_docs/​version-3.33/​reference/​resources/​globalnetworkpolicy.mdx Updates the 3.33 reference.
calico_versioned_docs/​version-3.33/​_includes/​content/​_rule.mdx Marks action as required.
calico_versioned_docs/​version-3.32/​reference/​resources/​globalnetworkpolicy.mdx Updates the 3.32 reference.
calico_versioned_docs/​version-3.32/​_includes/​content/​_rule.mdx Marks action as required.
calico_versioned_docs/​version-3.31/​reference/​resources/​globalnetworkpolicy.mdx Updates 3.31 naming and tier documentation.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Every version says the name is lowercase alphanumeric with optional hyphens and at most one period.
@ctauchen
ctauchen marked this pull request as ready for review October 19, 2026 16:18
@ctauchen
ctauchen requested a review from a team as a code owner October 19, 2026 16:18
@ctauchen ctauchen closed this Oct 19, 2026
@ctauchen ctauchen reopened this Oct 19, 2026
@ctauchen
ctauchen merged commit 6904790 into tigera:main Oct 19, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants