fix(web): handle bulk delete request failures - #309
Open
karaaslanz wants to merge 3 commits into
Open
karaaslanz wants to merge 3 commits into
karaaslanz wants to merge 3 commits into
Conversation
karaaslanz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulk-delete currently reports success and clears the full selection even when one of the delete API requests fails.
This change checks each delete result, preserves partial-success state by removing only IDs actually deleted, shows the existing failure toast when any group fails, and adds regression coverage for full success, full failure, and partial success.
Validation: GitHub Actions Platform Package Smoke run 34963974551 completed successfully across the repository’s 6-platform matrix, covering typecheck, build, Bun tests, and published-package smoke.
I did not run tests locally; GitHub Actions is the execution evidence.
AI-authored with human direction using OpenAI ChatGPT. The problem, source behavior, final diff, and CI results were reviewed before submission.