Repository navigation
Hide ToolTip on Esc - #357
Merged
Merged
Conversation
rwood-moz
approved these changes
Nov 13, 2026
rwood-moz
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
- Pulled the branch locally
- Ran the component tests, all passed included the updated
✓ unit test/components/ToolTip.test.js (15 tests) 39ms - Started storybook, verified an open ToolTip is closed when press ESC, except Tooltips with
visible: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
An open ToolTip can now be closed with pressing Escape. Tooltips forced open with
visible: trueignore that.Why?
The tooltip could only be hidden by moving the pointer or focus away, which violates WCAG 2.1 SC 1.4.13 (Content on Hover or Focus) and the ARIA APG tooltip pattern.
Limitations and Notes
Any
focusoutormouseleaveresets the dismissal, so with several focusable elements inside one anchor, tabbing between them shows the tooltip again, and moving only the pointer away while the trigger stays focused does as well. Escape is not stopped from propagating, so enclosing components (e.g.AppDrawer) still receive it.Applicable Issues
Closes #355
QA Log
visible: trueScreenshots
No UI change