Skip to content

chore(deps): weekly security pass 2026-11-18 (basic-ftp 6.2.6, e2e) - #1901

Merged
markstos merged 1 commit into
mainfrom
deps/2026-11-18-routine
Nov 18, 2026
Merged

markstos merged 1 commit into
mainfrom
deps/2026-11-18-routine

Conversation

@aaspinwall

Copy link
Copy Markdown
Contributor

Weekly Dependabot remediation pass (2026-11-18).

Alert

Alert Severity Scope Package Old → New Manifest
#452 Medium development basic-ftp (npm) 6.2.2 → 6.2.6 (fix floor 6.2.4) test/e2e/pnpm-lock.yaml

Uncaught TypeError in the MLSD directory-listing parser via __proto__ fact name causes DoS in Client.list(). Fixed in 6.2.4; this lift resolves to 6.2.6, the latest in range.

Decision

Option 1 — in-range lockfile lift (targeted; no manifest changes). basic-ftp is transitive: browserstack-node-sdk@1.73.4 → pac-proxy-agent@7.2.0 → get-uri@6.0.5 → basic-ftp. The stale basic-ftp@6.2.2 entries were removed from the packages:/snapshots: sections and re-resolved with pnpm@11.15.1 (repo's packageManager), then rewritten with pnpm install --lockfile-only. The diff touches only basic-ftp lines (4 insertions, 4 deletions, one file).

Note: get-uri@6.0.5 declares basic-ftp: ^5.0.2; the resolution to 6.2.6 is admitted by the pre-existing committed override basic-ftp@<6.2.1: ^6.2.1 in test/e2e/pnpm-workspace.yaml (added in a previous pass). No new override was introduced.

Cooling period

Advisory published 2026-10-30 — 19 days ago, past the 7-day cooling period.

Development scope only (E2E tooling); backend and frontend untouched. No coverage check required per policy.

@sonarqubecloud

Copy link
Copy Markdown

@devmount devmount left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@markstos markstos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Log

  • Minor, e2e/dev-only patch bump.

@markstos
markstos merged commit b0b1f15 into main Nov 18, 2026
11 checks passed
@markstos
markstos deleted the deps/2026-11-18-routine branch November 18, 2026 19:05
@github-actions

Copy link
Copy Markdown

Thanks for your contribution! Your pull request has been merged and is being deployed to our staging instance. If all goes well we'll include it in the next production deployment. We appreciate the time and effort you put into improving Thunderbird Appointment. If you haven't already, you're welcome to join our Matrix chat for contributors. It's where we discuss development and help each other out.
https://matrix.to/#/#tb-services:mozilla.org
Hope to see you there! 🌩️🐦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants