Repository navigation
fuzz: widen api_surface values and check root against a reference - #958
Draft
citizen-stig wants to merge 2 commits into
Draft
citizen-stig wants to merge 2 commits into
citizen-stig wants to merge 2 commits into
Conversation
Values now cover inline sizes, both sides of the leaf overflow threshold and multi-page overflow values (up to 32 KiB) instead of only 0/1/4096/4097 bytes. After every commit the database root is compared with build_trie over a model of the committed state. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #956
What
Two gaps in the
api_surfacefuzz target:MAX_LEAF_VALUE_SIZE= 1332) and never produced multi-page overflow values. Sizes now cover 0, 1–32, 33–1331, 1332–1333 (both sides of the threshold), 1334–4096, 4097–8192 and 8193–32768 bytes.db.root()withnomt_core::update::build_trieover aBTreeMapmodel of the committed state, usingBlake3Hasher::hash_valuefor value hashes. Bugs that corrupt the trie without breaking reads are now caught.Not changed
No reopen or rollback in
api_surface;grow_hashtablealready covers those. Witnesses returned byfinish()are still not verified.Run
🤖 Generated with Claude Code