Repository navigation
session: hash actuals for the merkle update on multiple threads - #951
Draft
citizen-stig wants to merge 3 commits into
Draft
citizen-stig wants to merge 3 commits into
citizen-stig wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 21, 2026
Contributor
Author
|
max parallelism must be configurable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session::finishhashes every written value on the calling thread before the merkle update can start. For sessions with many or large writes, this serial loop sits on the critical path of every commit.Changes
compact_actualshelper. It counts the written values to hash and picksthreads = min(actuals_concurrency, available_parallelism, written / 8192). With fewer than 2 threads, or fewer than 16,384 actuals, it runs inline as before. Otherwise it splits the actuals intothreadsequal chunks and runsto_compacton scoped threads.Options::actuals_concurrency(usize): the maximum number of hashing threads per session. Default 16; 1 hashes sequentially. Independent of commit and I/O worker concurrency.Touches the same lines of
Session::finishas #952. Whichever lands second needs a trivial rebase.Performance impact
No effect for sessions of up to ~24k keys, which use at most 2 threads. Above that, the gain grows with session size:
Session::finishis about 2.5% faster at 48k–96k keys, about 3–4% at 240k keys, and 5–6% at 960k keys (85–105 ms per session). The serial loop cost about 90–110 ns per key, which is all this PR can save.Session::finishtime (median of 6 runs, base → this PR):Per-session wall time without the fsync improves by the same absolute amount: −1% at 48k keys, −2.4 to −3.3% at 240k, −4.1 to −4.5% at 960k. Throughput including the durable commit is fsync-bound, so it moves within noise (+0 to +3%). Reads and
durable_commitare unchanged.How it was measured: benchtop transfer workload, built from master + #943 (seeded, reproducible workload) + #944, plus a
session_finishspan aroundSession::finish. Every run starts from a fresh copy of the same seeded 4M-account DB (-c 22 --buckets 4000000). The order is shuffled per repetition, with 6 repetitions per point, and runs are pinned to 6 cores + SMT siblings: