Skip to content

fix(onboarding): stop the "With my team" plan from sending new signups to a 404 - #4

Closed
threos wants to merge 2 commits into
mainfrom
claude/fix-signup-404-l034pl
Closed

threos wants to merge 2 commits into
mainfrom
claude/fix-signup-404-l034pl

Conversation

@threos

@threos threos commented Oct 16, 2026

Copy link
Copy Markdown
Owner

Requested by Eray · project thread

What does this PR do?

Before: after signing up, the plan picker at /onboarding/getting-started offers "For personal use" and "With my team". Choosing the team plan and pressing Continue pushed /onboarding/teams/details, a page Cal.diy removed, so the user landed on "This page does not exist". The same happened to anyone whose persisted onboarding store still held "team" or "organization".

After: Continue always goes to /onboarding/personal/settings, the only onboarding flow that exists in this fork. onboarding-v3 is enabled globally (migration 20260213000000_enable_onboarding_v3_globally), so every new signup goes through this picker.

How: handleContinue in apps/web/modules/onboarding/getting-started/onboarding-view.tsx no longer branches on the plan. The plan list itself is left alone, because a separate change is removing the paid team option from onboarding.

Visual Demo (For contributors especially)

N/A. The reported screenshot shows the app's 404 page; the fix is a route change.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • TZ=UTC yarn vitest run apps/web/modules/onboarding/getting-started/onboarding-view.test.tsx covers Continue for the personal, team, organization and no-selection cases.
  • Manually: sign up, pick "With my team", press Continue, and confirm you land on the personal settings step.

Not covered here: CompanyEmailOrganizationBanner (profile settings) and OnboardingContinuationPrompt still reference removed /onboarding/organization/* and /onboarding/teams/* routes. Neither is reachable from signup today.

🤖 Generated with Claude Code

https://claude.ai/code/session_013jArPgym5pEewcZ8kSiN1i


Generated by Claude Code

…d of the removed team pages

Choosing "With my team" on /onboarding/getting-started pushed
/onboarding/teams/details, which Cal.diy removed, so new signups hit a 404.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013jArPgym5pEewcZ8kSiN1i
@threos threos self-assigned this Oct 16, 2026
@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tikket-dev Ready Ready Preview Oct 16, 2026 3:04pm UTC

Request Review

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013jArPgym5pEewcZ8kSiN1i

threos commented Oct 16, 2026

Copy link
Copy Markdown
Owner Author

Closing as superseded by #6. That PR makes the same handleContinue change, so "With my team" no longer leads to /onboarding/teams/details. It also removes the team option, fully resets a persisted "team" plan, and stops rendering the continuation prompt that linked to the missing team and organization pages. Keeping both PRs open would only cause a conflict in onboarding-view.tsx.


Generated by Claude Code

This branch was successfully deployed

1 active deployment
Preview — 79f3c003 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants