Skip to content

Remove the redundant unknown annotation on the caught error - #463

Merged
threeal merged 1 commit into
mainfrom
remove-unknown-catch-annotation
Nov 3, 2026
Merged

threeal merged 1 commit into
mainfrom
remove-unknown-catch-annotation

Conversation

@threeal

@threeal threeal commented Nov 2, 2026

Copy link
Copy Markdown
Owner

Closes #462.

The top-level catch in src/main.ts is now a plain catch (err), matching threeal/action-starter. The built dist/main.js is unchanged, since the build strips type annotations.

The (err: unknown) => err callbacks in src/fs.test.ts stay as they are, since a promise's .catch callback types its argument as any rather than unknown, so the annotation there isn't redundant.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Alfi Maulana <alfi.maulana.f@gmail.com>
@threeal threeal self-assigned this Nov 2, 2026
@threeal threeal added the enhancement New feature or request label Nov 2, 2026
@threeal threeal added this to the Version 2.2.0 milestone Nov 2, 2026
@threeal threeal added this to Granary Nov 2, 2026
@threeal threeal moved this to Harvestable in Granary Nov 2, 2026
@threeal threeal removed this from Granary Nov 3, 2026
@threeal
threeal merged commit 57cc010 into main Nov 3, 2026
7 checks passed
@threeal
threeal deleted the remove-unknown-catch-annotation branch November 3, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the redundant unknown annotation on the caught error

1 participant