Skip to content

feat(panels): shared collapsible and resizable panel layout - #546

Open
Clupai8o0 wants to merge 1 commit into
thoth-tech:11.0.xfrom
ontrack-features-t2-2026:upstream-pr/panels
Open

Clupai8o0 wants to merge 1 commit into
thoth-tech:11.0.xfrom
ontrack-features-t2-2026:upstream-pr/panels

Conversation

@Clupai8o0

@Clupai8o0 Clupai8o0 commented Sep 27, 2026 •

Copy link
Copy Markdown

What this is

A shared panel layout for pages with side by side columns. Each column can be collapsed, resized by dragging, or shown full screen, and the page remembers those choices in the browser. The task dashboard, the project dashboard, the task inbox and the unit task list use it. The files that use it are in the theme, ui, a11y, ppi-cpd and redesign PRs, so this one goes in before them.

What is in it

  • src/app/common/panel-layout/panel-layout.component.* and panel.component.*: the layout and one column in it, with minimum widths and a drag handle between columns.
  • panel-collapse-button.component.* and panel-fullscreen-button.component.*: the buttons each column shows in its own top corner.
  • panel-state.service.ts: keeps each column's collapsed state and width per page in localStorage.
  • panel-layout.token.ts: lets a column find the layout it sits in.
  • 1 spec file, panel-layout.component.spec.ts.
  • This PR is new in the set on 28 Sep 2026. These files were in our org 11.0.x but in no PR before, so the set did not build. It type-checks on thoth-tech 11.0.x alone.

How this set of PRs works

This is one of 24 PRs from the Thoth Tech T2 2026 Features team (9 api, 14 web, 1 deploy), one per feature per repo. Each one carries that feature's files, taken from our team org's 11.0.x branch, and applied straight onto thoth-tech 11.0.x. Every file is in exactly one PR. Some files are shared between features, so a PR on its own may not build. The demo PR in each repo (api #127, web #544) is imported by earlier PRs too, so it has to go in with the rest, not be dropped. Merged in the order below, the set equals our org 11.0.x minus team docs, evidence files, org-only CI and dev setup files. No app code or tests are left out.

On 28 Sep 2026 the set was brought up to our org's latest merges (api ontrack-features-t2-2026/doubtfire-api#178, web ontrack-features-t2-2026#281 and ontrack-features-t2-2026#282, deploy ontrack-features-t2-2026/doubtfire-deploy#41). Most PRs got one more commit for that. Two web PRs are new, panels (#546) and celebrate (#547), for files that were in no PR before.

Merge order, api first, then web, then deploy. In web, panels goes before the pages that use it, and celebrate goes after a11y, whose confetti service it needs.

Built against

  • api: thoth-tech 11.0.x @ dc76a5a0e, taken from org 11.0.x @ a9589b302
  • web: thoth-tech 11.0.x @ 20d1f380c, taken from org 11.0.x @ 0b8a20344
  • deploy: thoth-tech 11.0.x @ 58905969e, taken from org 11.0.x @ 8e560f7e0

Testing

Checked on 28 Sep 2026 with all the branches merged together. This PR was not tested on its own, see above.

  • web: with all 14 web branches merged onto thoth-tech 11.0.x, npm run test:ci runs 2603 tests in 290 files, all passing, and npm run lint and ng build pass. The merged set's app code is the same as our org 11.0.x after fix(profile): save a changed summary email cadence ontrack-features-t2-2026/doubtfire-web#282, where CI passed test, lint (22) and build (22).
  • api: the full Minitest suite passes on the nine api PRs merged onto thoth-tech 11.0.x. 1799 tests, 20182 assertions, 0 failures, 0 errors, 0 skips. It ran through our CI on branch check/upstream-combined-28sep (run), and the database schema check and RuboCop pass there too. The set differs from our org 11.0.x only by the left-out docs, evidence, CI and dev setup files, none of them app code.
  • deploy: production/tests/validate_test.sh, verify_pwa_test.py, publish_release_test.py and nginx_upload_test.py pass. The production compose file loads with docker compose config against .env.production.example, and the development and .devcontainer ones load as they are.

Contributors

Samridh Limbu

Adds src/app/common/panel-layout from
#281: the panel layout, its
collapse and full screen buttons and the panel state service. The ui,
ppi-cpd, redesign and theme PRs use it, so this one merges before those.
This was referenced Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants