topology2: Add support for SYMLINKs for topologies and convert the WCL DMIC functions to symlink to the PTL ones. - #11174
Open
ujfalusi wants to merge 2 commits into
Open
topology2: Add support for SYMLINKs for topologies and convert the WCL DMIC functions to symlink to the PTL ones.#11174ujfalusi wants to merge 2 commits into
ujfalusi wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new build commands should be adjusted to properly quote paths/arguments (and use VERBATIM where appropriate) to avoid build failures in common environments (e.g., build directories with spaces).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR extends the topology2 build system to support generating topology outputs as symbolic links (via a new SYMLINKS list), and uses this to deduplicate WCL DMIC “function” topologies by symlinking them to the equivalent PTL outputs, reducing deployment size.
Changes:
- Add a
SYMLINKSmechanism in topology2 production builds to generate.tplgsymlinks. - Convert WCL DMIC function topologies to symlinks pointing to PTL DMIC function topologies.
- Update the top-level topology2 deployment copy step to preserve symbolic links.
File summaries
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-ace3.cmake | Removes explicit WCL DMIC topology targets and adds SYMLINKS entries mapping WCL DMIC names to PTL DMIC outputs. |
| tools/topology/topology2/production/CMakeLists.txt | Implements building .tplg symlinks from SYMLINKS entries as part of topology2_prod. |
| tools/topology/topology2/CMakeLists.txt | Switches deployment copying to preserve symlinks when staging topology artifacts under target/. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+11
to
+13
| # copy the topology files only to target, preserving symbolic links | ||
| COMMAND sh -c "cp -a production/*.tplg ${CMAKE_CURRENT_BINARY_DIR}/target/sof-ipc4-tplg/" | ||
| COMMAND sh -c "cp -a development/*.tplg ${CMAKE_CURRENT_BINARY_DIR}/target/development/" |
Comment on lines
+45
to
+49
| add_custom_command( | ||
| OUTPUT ${link_name}.tplg | ||
| COMMAND ${CMAKE_COMMAND} -E create_symlink ${link_target}.tplg ${link_name}.tplg | ||
| DEPENDS ${link_target}.tplg | ||
| ) |
Some topologies are byte-for-byte identical to an existing one and only need to be reachable under a different name. Add a SYMLINKS list, processed alongside TPLGS in production/CMakeLists.txt, that creates a real symlink instead of building a duplicate topology. cmake -E copy_if_different dereferences symlinks when deploying the build output, turning them back into regular file copies. Switch to "cp -a" so the deploy step preserves symlinks as symlinks. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
WCL DMIC function topologies are byte-for-byte identical to the PTL ones, only reachable under a different name. Drop the duplicated TPLGS entries and list them in SYMLINKS instead, so they are built as symlinks to the PTL topologies rather than separately compiled duplicates. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
kv2019i
approved these changes
Sep 7, 2026
ujfalusi
force-pushed
the
peter/wcl-dmic2
branch
from
September 7, 2026 12:10
10957a1 to
dd2eeae
Compare
Contributor
Author
|
Changes since v1:
|
PR 11174: test resultsRun date: 2026-09-07 12:57 UTC Tested commit: dd2eeae5fabadb1cefa96059f80496885ed4ace6
|
Contributor
Author
|
should be taken for 2.15 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for SYMLINKS array which can be used to create a symlink to an existing topology with a different name to handle duplication.
The first user of this will be WCL's DMIC function topologies since they are identical to the PTL functions.
The resulting target will look like this:
We can use this symlink mode to reduce the size of the topology deployment by converting the identical topologies to symlinks later.