Repository navigation
Build a model on the front page instead of describing one - #10
Merged
Merged
Conversation
The gallery opened with three paragraphs claiming a model would assemble itself, and six cards of equal weight underneath: the bundled models, free build, the set search and the drop target all read as the same offer. The header is now the demonstration. A canvas behind the type loads the real Example Car through the same loader the builder uses and assembles it in the eight steps its author wrote, holds it, lifts it apart and starts again. Drag turns it. It is a packed LDraw file rather than a hand-made stand-in, because a hero that fakes the product is the one thing a hero must not do, and it costs 44ms: the model is 61 bricks and the import happens after mount. The copy above it is down to one heading, since the model says the rest. Underneath, the ways in are ranked. Search leads, at three fifths of the row with room for three sets to press rather than type, because it reaches all 1,470 official sets where everything below it reaches one. Free build sits beside it as the same decision made the other way. Bringing your own file became a strip rather than a tile: it is a real way in, but the only one that assumes you already have an .ldr on disk. The bundled models follow. Also in here, from the same pass over the page: - Icon-only buttons are square. The theme toggle was 4px wider than it was tall everywhere it appeared. `.hud-square` sizes both axes from one line of type plus the padding, so it matches the labelled buttons beside it. - Opening a set shows a spinner and an indeterminate bar, and neither the bar nor the note that goes with it moves anything: the suggestions are hidden rather than unmounted so they hold the row, and the working note is written to the length of the licence one. Packing a cold set is seconds of nothing visible happening. - The back link out of the builder has a 112x32 target instead of 72x12, with the padding cancelled by margin so nothing moved. - The OG card carries the page's heading and one line, not a paragraph and a feature list. - The favicon is the wordmark folded into a 2x2. The 2x2 brick it replaces was a drawing of a brick, and studs and highlights are mush at 16px. - A footer credit.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gallery opened with three paragraphs claiming a model would assemble itself, and six cards of equal weight underneath: the bundled models, free build, the set search and the drop target all read as the same offer.
The header is now the demonstration
A canvas behind the type loads the real Example Car through the same
loadModelthe builder uses, and assembles it in the eight steps its author wrote, holds it, lifts it apart in reverse and starts again. Drag turns it.It is a packed LDraw file rather than a hand-made stand-in, because a hero that fakes the product is the one thing a hero must not do. It is also cheap: 61 bricks, imported after mount,
car loaded in 44ms: colours 11ms, fetch 3ms, parse 28ms, flatten 3ms, layout 0ms. The loop parks when the header scrolls out of view,prefers-reduced-motionskips straight to the built model, and the scene reads--scene-env/--scene-shadowoff the stylesheet so it follows the theme.The copy above it is down to one heading, since the model says the rest.
Two layout notes worth a reviewer's eye:
WIDE_PXis Tailwind'slgbecause the veil picks its direction at that breakpoint. They were 900 and 1024 for a while, and in the gap the model was placed for the side-by-side layout while the veil was still the stacked one, which buried the car in the heavy end of a gradient.ground/0, nottransparent.transparentis transparent black, and a gradient run to it in oklab passes through colours that are neither.The ways in are ranked
Search leads, at three fifths of the row and with three sets to press rather than type, because it reaches all ~1,470 official sets where everything below it reaches one. Free build sits beside it as the same decision made the other way. Bringing your own file became a strip rather than a tile: a real way in, but the only one that assumes you already have an
.ldron disk. The bundled models follow.Also in here, from the same pass
.hud-squaresizes both axes from one line of type plus the padding, so it stays square and matches the labelled buttons beside it.aspect-ratiodoes not work here — a flex item is sized from its content first, so the ratio loses to a 14px icon.Verification
pnpm check,pnpm typecheck,pnpm test(541 passing) andpnpm buildare clean. The front page,/freeand/build/pyramidwere checked in a real browser at 1440, 960 and 390, in both themes, including the drag, the loading state and the favicon at 16/24/32/64 on light and dark chrome.One copy assertion in
OpenSetCard.test.tsxchanged with the working note's wording; the test checks the same thing.Not done
The README does not mention the hero. Happy to add a paragraph about the front page loading a real model if that is wanted.