Skip to content

Finished project - #792

Closed
hakonRein wants to merge 2 commits into
the-csharp-academy:mainfrom
hakonRein:main
Closed

hakonRein wants to merge 2 commits into
the-csharp-academy:mainfrom
hakonRein:main

Conversation

@hakonRein

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakonRein Thanks for submitting. It's looking good but each round has only one question, so this requirement isn't fulfilled:

Image

Could you please fix so we can approve? Once you make your changes just commit them, no need to create a new PR.

💁‍♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.

@TheCSharpAcademy TheCSharpAcademy self-assigned this Oct 29, 2026
@TheCSharpAcademy

TheCSharpAcademy commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

@hakonRein Project approved! 😄✅ And well done for completing the challenges! I recommend you always do that, as it pushes you and makes you learn faster. Your project is clean, tidy, concise and to the point. And you're using only one method for all operations, great work!

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
🔍️ Your current implementation works, but the main loop handles menu selection, number generation, validation, scoring, and history management. Consider extracting some of this functionality into methods such as PlayGame(), GenerateQuestion(), and DisplayHistory(). This will improve readability and make the application easier to maintain as you introduce additional features.

🔍️Your totalPoints variable accumulates points across every game played, so the score doesn't get reset between rounds.
image

🕵️‍♀️Also, have a look at our style guide since there are a few issues in your code. e.g. lots of unnecessary comments, as per picture below. You can read our code conventions here🤓.
image

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

👪Oh and if possible join our Discord Community and add your username to your profile so you can be part of the community as well. 😁

Overall great work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants