Skip to content

Fix wrong v2 hashes on big-endian PPC64 with VSX #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SChernykh merged 2 commits into from
Oct 13, 2026
Merged

Fix wrong v2 hashes on big-endian PPC64 with VSX #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6313b96
Fix v2 F/E mixing on big-endian PPC64 with VSX
thomasbuilds Oct 12, 2026
d6a4911
Remove unused vector helpers that are wrong on big-endian
thomasbuilds Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 8 additions & 21 deletions src/intrin_portable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,14 +260,6 @@ FORCE_INLINE rx_vec_f128 rx_sqrt_vec_f128(rx_vec_f128 a) {
return (rx_vec_f128)vec_sqrt(a);
}

FORCE_INLINE rx_vec_i128 rx_set1_long_vec_i128(uint64_t a) {
return (rx_vec_i128)vec_splat2sd(a);
}

FORCE_INLINE rx_vec_f128 rx_vec_i128_vec_f128(rx_vec_i128 a) {
return (rx_vec_f128)a;
}

FORCE_INLINE rx_vec_f128 rx_set_vec_f128(uint64_t x1, uint64_t x0) {
return (rx_vec_f128)(__m128ll){x0,x1};
}
Expand All @@ -277,11 +269,19 @@ FORCE_INLINE rx_vec_f128 rx_set1_vec_f128(uint64_t x) {
}

FORCE_INLINE rx_vec_f128 rx_cast_vec_i2f(rx_vec_i128 a) {
#if defined(NATIVE_LITTLE_ENDIAN)
return (rx_vec_f128)a;
#else
return (rx_vec_f128)vec_perm((__m128i)a, (__m128i)a, (__m128i){4,5,6,7, 0,1,2,3, 12,13,14,15, 8,9,10,11});
#endif
}

FORCE_INLINE rx_vec_i128 rx_cast_vec_f2i(rx_vec_f128 a) {
#if defined(NATIVE_LITTLE_ENDIAN)
return (rx_vec_i128)a;
#else
return (rx_vec_i128)vec_perm((__m128i)a, (__m128i)a, (__m128i){4,5,6,7, 0,1,2,3, 12,13,14,15, 8,9,10,11});
#endif
}

FORCE_INLINE rx_vec_f128 rx_xor_vec_f128(rx_vec_f128 a, rx_vec_f128 b) {
Expand Down Expand Up @@ -632,19 +632,6 @@ FORCE_INLINE rx_vec_f128 rx_sqrt_vec_f128(rx_vec_f128 a) {
return x;
}

FORCE_INLINE rx_vec_i128 rx_set1_long_vec_i128(uint64_t a) {
rx_vec_i128 x;
x.u64[0] = a;
x.u64[1] = a;
return x;
}

FORCE_INLINE rx_vec_f128 rx_vec_i128_vec_f128(rx_vec_i128 a) {
rx_vec_f128 x;
x.i = a;
return x;
}

FORCE_INLINE rx_vec_f128 rx_set_vec_f128(uint64_t x1, uint64_t x0) {
rx_vec_f128 v;
v.i.u64[0] = x0;
Expand Down
10 changes: 10 additions & 0 deletions src/tests/tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,16 @@ int main() {
assert(equalsHex(state, "fa89397dd6ca422513aeadba3f124b5540324c4ad4b6db434394307a17c833ab"));
});

runTest("rx_cast_vec_f2i / rx_cast_vec_i2f", true, []() {
alignas(16) uint8_t in[16], out[16];
for (int i = 0; i < 16; ++i)
in[i] = (uint8_t)(0x11 * i + 1);
rx_store_vec_i128((rx_vec_i128*)out, rx_cast_vec_f2i(rx_load_vec_f128((const double*)in)));
assert(memcmp(in, out, sizeof(in)) == 0);
rx_store_vec_f128((double*)out, rx_cast_vec_i2f(rx_load_vec_i128((const rx_vec_i128*)in)));
assert(memcmp(in, out, sizeof(in)) == 0);
});

randomx::NativeRegisterFile reg;
randomx::BytecodeMachine decoder;
randomx::InstructionByteCode ibc;
Expand Down
Loading