Repository navigation
Surface WCI limit errors as ResourceExhausted instead of Internal - #13164
Open
zainawaisn wants to merge 2 commits into
Open
zainawaisn wants to merge 2 commits into
zainawaisn wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
ResourceExhaustedwith a clear message, instead of a generic "something went wrong".WorkerDeploymentLimitExceededmetric, so we can see which namespaces are affected.FailedPreconditionerrors from WCI on the compute config update API also come back with their real error code now. They were returned as Internal before.Why?
The WCI instance limit error was retried 5 times, then returned as
Internal. Users only seesomething went wrong, please retry. They now getResourceExhausted: reached maximum worker controller instances in namespace (n).Open bug ticket: https://temporalio.atlassian.net/jira/software/c/projects/COM/boards/1520?selectedIssue=COM-375
How did you test it?
Added
TestWciClientErrorToActivityErrorunit test. Theclient.gomappings are not tested directly.Potential risks
Low. This only affects errors that were previously returned as
Internal.