Repository navigation
feat: read codec-encoded external storage references - #1814
Open
jmaeagle99 wants to merge 1 commit into
Open
jmaeagle99 wants to merge 1 commit into
jmaeagle99 wants to merge 1 commit into
Conversation
jmaeagle99
marked this pull request as ready for review
November 18, 2026 00:46
jmaeagle99
force-pushed
the
extstore-encode-refs
branch
from
November 19, 2026 00:43
bcdec07 to
cc6c86c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
__temporal_external_storage_reference: "true"is decoded with the payload codec, one reference at a time, using the same serialization context as the rest of the message. A marked payload that doesn't decode to a reference fails with the new TMPRL1106 (ExternalStorageError::UndecodableReference). One with no storage configured fails with TMPRL1105.external_payloads. This is switched on by a hiddenExternalStorage::with_encoded_references, which defaults tofalse.store_external_payloadsandretrieve_external_payloadstake a&SerializationContextData. Each worker and client call site builds one context and passes it to both its codec calls and its storage calls.Why?
A reference written in plain form puts its claim data, such as bucket and key names, into history unencrypted, even when a codec is configured. Encoding references fixes that. Readers have to ship first, because a worker that can't decode an encoded reference can't find it at all. That's why writing ships here but stays off: it can be turned on in a later release by changing the default, once workers have upgraded.
Checklist
Unit tests for the encode and decode passes, and integration tests covering an encoded round trip read by a client with writing off, signals, queries and memos, and a worker without the codec failing with TMPRL1106.
Rustdoc only. The changelog fragment is included.