Skip to content

feat(extstore): report external storage metrics on workflow task completions - #677

Open
jmaeagle99 wants to merge 4 commits into
mainfrom
extstore-completion-metrics
Open

jmaeagle99 wants to merge 4 commits into
mainfrom
extstore-completion-metrics

Conversation

@jmaeagle99

@jmaeagle99 jmaeagle99 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What was changed

  • Measure the payloads external storage retrieves into each workflow activation and offloads from its completion: count, total size, wall-clock duration, and drivers used.
  • Report them to core on the completion (payload_download_metrics, payload_upload_metrics), including what a failing pass moved before it failed.

Why?

So core's slow workflow task warning (TMPRL1104) shows how much of the task went to external storage, and through which drivers.

Checklist

  1. Closes SDK should log when WFT completion takes a long time - Ruby #678

  2. How was this tested: Added runner and worker tests.

  3. Any docs updates needed? No.

@jmaeagle99
jmaeagle99 requested a review from a team as a code owner November 17, 2026 19:21
@jmaeagle99 jmaeagle99 added the skip-changelog PR changes do not require changelog updates label Nov 17, 2026
@jmaeagle99 jmaeagle99 changed the title feat: report external storage metrics on workflow task completions feat(extstore): report external storage metrics on workflow task completions Nov 17, 2026
@chris-olszewski
chris-olszewski force-pushed the extstore-completion-metrics branch from a941f10 to 9b3492a Compare November 18, 2026 18:38

@chris-olszewski chris-olszewski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog PR changes do not require changelog updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK should log when WFT completion takes a long time - Ruby

2 participants