Repository navigation
feat(extstore): decode extstore references that were encoded by a codec. - #671
Open
cconstable wants to merge 3 commits into
Open
cconstable wants to merge 3 commits into
cconstable wants to merge 3 commits into
Conversation
cconstable
marked this pull request as ready for review
November 16, 2026 22:10
jmaeagle99
reviewed
Nov 17, 2026
cconstable
force-pushed
the
extstore-encode-refs
branch
from
November 18, 2026 21:25
13d1e89 to
a4fe49c
Compare
jmaeagle99
approved these changes
Nov 19, 2026
jmaeagle99
left a comment
Contributor
There was a problem hiding this comment.
I approve from an external storage point of view. Would like to see if @chris-olszewski has any feedback.
|
|
||
| def decode(payloads) | ||
| payloads.map do |p| | ||
| next p unless p.metadata['encoding'] == 'test/base64' |
Contributor
There was a problem hiding this comment.
This automatically weakens the strict nature of this codec for all tests. Consider subclassing or adding a optional parameter to allow passthrough when encoding doesn't match with a default of false.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Workers and clients now read external storage references that were encoded by the payload codec and marked with
__temporal_external_storage_referencemetadata. Each marked reference is decoded with the configured codec, then retrieved from storage as before. This release only reads encoded references. Writing them stays disabled until a later release.ExternalStorageNotConfiguredError(TMPRL1105) before anything is decoded.ExternalStorageReferenceDecodeError(TMPRL1106).No configuration changes. Encoded references are decoded with the codec you already have:
Why
References hold driver claim data such as bucket names and object keys. Until now they were written to history unencoded, even when a codec encrypted everything else.
Spec: https://github.com/temporalio/features/blob/encoding-payload-refs/features/external_storage/spec.md#wire-format