Repository navigation
Add opt-in header codec processing - #3165
Merged
Merged
Conversation
Sushisource
force-pushed
the
normalize-header-conversion
branch
7 times, most recently
from
October 30, 2026 00:51
f0ef77f to
37a747d
Compare
Sushisource
marked this pull request as ready for review
October 30, 2026 22:08
Sushisource
force-pushed
the
normalize-header-conversion
branch
from
November 5, 2026 22:31
37a747d to
cb0e386
Compare
Quinn-With-Two-Ns
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
ContextPropagator.encodeHeaders()and OpenTracing/OpenTelemetry options using the configured client's payload codec, compatible with existing propagator implementations.Breaking changes: None. Existing producers default to false; custom converter wrappers can forward
PayloadCodecProviderto expose their codec.Server PR: Not required.
Why?
Part of temporalio/features#850. Tracing and context propagators can opt into the configured client codec without double-encoding unrelated user-supplied headers or changing existing defaults.
Checklist
Latest rebase validation
Rebased onto
mainatfdd71321; current headcb0e386d. Resolved the changelog by retaining both sets of entries and the activity executor import conflict by retaining both header-codec and payload-limit imports. No README diff remains.Post-rebase
spotlessApplyand targeted Gradle tests passed forHeaderUtilsTest,ActivityTaskExecutorsTest,HeaderCodecClientTest,ScheduleProtoUtilTest,RootWorkflowClientInvokerStorageTargetTest,SyncWorkflowContextTest, and OpenTracingHeaderCodecTest. This used a scratch-only Gradle init script with the exact pinned API/cloud proto sources and submodule update tasks disabled; the unmodified formatting invocation was blocked by populated partial submodule directories. Full test suites and cross-language tests were not rerun after rebasing.