Repository navigation
Drop Python 3.10 - #424
Closed
DABH wants to merge 2 commits into
Closed
Drop Python 3.10#424DABH wants to merge 2 commits into
DABH wants to merge 2 commits into
Conversation
Temporal Python SDK 1.36 requires Python 3.11, and the AI integration samples now depend on it, so the samples require 3.11 too: the root dependency floor is temporalio 1.36, the CI matrix runs 3.11 and 3.14, ruff targets py311, and the README says so. The lock no longer forks by Python version: temporalio 1.36.1, nexus-rpc 1.5.0, temporalio-langsmith 0.1.1 and the langchain, langgraph, langsmith, anthropic, idna and networkx forks collapse to one version each, and the 3.10-only exceptiongroup and tomli backports go.
On temporalio 1.36 the SDK's ClientConnectConfig carries plugins, so mypy rejects Client.connect(**config, plugins=[...]) as passing plugins twice. The SDK's load_client_connect_config docstring asks callers to combine their plugins with the config's plugins rather than pass them separately; these 17 sites now do that on the typed config and pass **config alone.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires Python 3.11. Temporal Python SDK 1.36 dropped 3.10, and the AI integration samples depend on 1.36, so the root dependency floor moves to
temporalio>=1.36, the CI matrix runs 3.11 and 3.14, ruff targets py311, and the README says so. The lock stops forking by Python version: temporalio 1.36.1, nexus-rpc 1.5.0, temporalio-langsmith 0.1.1 and the langchain, langgraph, langsmith, anthropic, idna and networkx pairs collapse to one version each, and the 3.10-only exceptiongroup and tomli backports go.On 1.36 the SDK's
ClientConnectConfigcarriesplugins, so the 17Client.connect(**config, plugins=...)calls now add their plugin to the config'spluginsand pass**config, as theload_client_connect_configdocstring asks. #418 carries the same 17 sites with adict[str, Any]copy for the 3.10 cell; whichever of the two merges second drops the overlap.