Repository navigation
Add external storage sample - #814
Merged
Merged
Conversation
jmaeagle99
requested review from
a team,
antmendoza and
tsurdilo
as code owners
November 10, 2026 23:28
cconstable
reviewed
Nov 12, 2026
Quinn-With-Two-Ns
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
externalstoragesample: a workflow passes a large order list between two activities.ZlibPayloadCodeccompresses each payload, and the S3 driver offloads any payload still over 256 KiB to S3.temporal-payload-storage-s3driver-awssdkv2,software.amazon.awssdk:s3andorg.gaul:s3proxytocore. S3Proxy raises the resolved AWS SDK from 2.20.91 to 2.54.13 and logback from 1.5.6 to 1.6.3.org.gaulloggers to WARN, so the mock doesn't print S3Proxy's Jetty startup output.Why?
It shows a complete working setup with the S3 driver, a payload codec, and a local S3 endpoint. The README shows which payloads end up in S3 and which stay in history, and how a codec changes what gets offloaded and what gets stored.
Checklist
How was this tested: Ran the sample end to end against a dev server. The order list was offloaded to S3 and every other payload stayed inline.
Any docs updates needed? No