Skip to content

Bump Temporal server ref and update repeated-update link expectation - #558

Merged
chrsmith merged 2 commits into
mainfrom
chrsmith/bump-server-repeated-update-links
Nov 18, 2026
Merged

chrsmith merged 2 commits into
mainfrom
chrsmith/bump-server-repeated-update-links

Conversation

@chrsmith

Copy link
Copy Markdown
Contributor

What changed?

  • Bump the integration-test dev server (mise.toml _.server.ref) from temporal@0425053 (Aug 20) to temporal@de3cfe9 (current main).
  • Update the TestKitchenSink/NexusOperation/Sync/Update history matcher. The repeated Update's NexusOperationCompleted link is now expected to be an eventRef to EVENT_TYPE_WORKFLOW_EXECUTION_UPDATE_ACCEPTED, instead of a requestIdRef.

Why?

The bump picks up temporalio/temporal#11925 ("Fix links for repeated updates"). That PR intentionally changed this behavior.

The test runs a Nexus Update, then repeats the same Update ID with a new request ID. The repeat is never written to the target's history. Before #11925, its link referenced its own request ID, so it pointed at an event that doesn't exist. The server now links to the original Update's accepted event by event ID. The old expectation was written against the pre-#11925 server, so it asserted the dangling link.

I confirmed the cause by running the test against temporal@763c820. That commit is just before #12956 ("Sanitize Nexus return-path links") and already includes #11925. It fails the same way and records the same eventRef link, so #12956 isn't involved.

Getting past #11925 is also a prerequisite for testing newer server features in Omes, such as worker callbacks on standalone Nexus operations.

How did you test it?

  • covered by existing tests
  • added new test(s)
  • tested manually

Locally against temporal@de3cfe9:

  • TestKitchenSink/NexusOperation/Sync/Update/go passes. It failed before the matcher change.
  • The Go-module suites pass apart from the worker-language failures below: root packages, including scenarios and loadgen/kitchensink, and workers/go.
  • In loadgen, the Go, Java, and Python TestKitchenSink cases pass.
  • The Ruby, Rust, TypeScript, and .NET cases fail locally because their workers can't be built or started on my machine. They fail during dependency install, cargo build, proto-gen, or because the .NET runtime is missing, not on server behavior. CI covers those languages.

Potential risks

This is a jump of about three months of server changes, so other integration tests could start behaving differently in CI. The local Go, Java, and Python runs found no other differences.

🤖 Generated with Claude Code

Bump the dev server used by integration tests to temporal@de3cfe9 (current
main). Among other changes, this picks up temporalio/temporal#11925 ("Fix
links for repeated updates").

A Nexus Update operation that repeats an already-completed Update ID is not
written to the target's history, so before #11925 its link pointed at a
request ID with no event behind it. The server now links it to the original
Update's accepted event by event ID instead. Update the
NexusOperation/Sync/Update history matcher to expect that eventRef link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chrsmith
chrsmith requested review from a team as code owners November 17, 2026 18:40
@chrsmith
chrsmith requested review from S15 and tekkaya November 17, 2026 22:41
@chrsmith

Copy link
Copy Markdown
Contributor Author

So the build is failing because of a breaking change in the Rust SDK?

#33 121.7 2026-11-17T22:49:33.967Z	DEBUG	workerctl/log.go:31	   Compiling temporalio-sdk v1.2.0 (/app/repo/crates/sdk)
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	error[E0308]: mismatched types
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	  --> src/workflow_nexus.rs:47:47
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	   |
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	47 |         Err(failure) => return finish_failure(failure, cancelling).map(|()| None),
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	   |                                -------------- ^^^^^^^ expected `Failure`, found `NexusOperationError`
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	   |                                |
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	   |                                arguments to this function are incorrect
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	   |
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	note: function defined here
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	  --> src/workflow_nexus.rs:93:4
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	   |
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	93 | fn finish_failure(failure: Failure, intentional_cancel: bool) -> WorkflowResult<()> {
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	   |    ^^^^^^^^^^^^^^ ----------------
#33 140.2 2026-11-17T22:49:52.416Z	DEBUG	workerctl/log.go:31	
#33 140.9 2026-11-17T22:49:53.091Z	DEBUG	workerctl/log.go:31	For more information about this error, try `rustc --explain E0308`.

From Claude:

**`build-worker-from-source (rust, sdk-rust)`: a breaking change in the Rust SDK merged today**
- This job builds Omes's Rust worker against the latest `temporalio/sdk-rust` source; the checkout has no `ref`, so it tracks that repo's default branch.
- sdk-rust #1660 "Add experimental typed Nexus workflow clients" (`a5d7742e8`, merged today) adds a `NexusOperationError` enum. Starting a Nexus operation from a workflow now fails with that type instead of a `Failure`.
- Omes still passes the old type, so it no longer compiles. The error is at `workers/rust/src/workflow_nexus.rs:47`: `expected Failure, found NexusOperationError`.
- The last `main` run (Nov 13) predates #1660 and passed. Any Omes PR, and `main` itself, will hit this until the worker is updated.
- The normal Rust build (`build-worker (rust)`) passed because it uses the pinned release (`temporalio-sdk = "=1.1.0"`), which doesn't have the new type yet.

It seems strange to use a pinned release in some contexts, but not others. I might open another PR to fix that and get that squared away.

… version

sdk-rust main contains an unreleased breaking change to the Nexus operation
start error type (temporalio/sdk-rust#1660), which breaks building the omes
Rust worker from source. The rest of CI builds against the exact
temporalio-sdk version pinned in workers/rust/Cargo.toml, so check out the
matching tag here instead of the default branch. Other SDKs are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chrsmith
chrsmith merged commit d079d82 into main Nov 18, 2026
104 of 105 checks passed
@chrsmith
chrsmith deleted the chrsmith/bump-server-repeated-update-links branch November 18, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants