Skip to content

Retain original throughput starts across iteration retries - #539

Open
lilydoar wants to merge 3 commits into
mainfrom
lilydoar/throughput-original-start-v2
Open

lilydoar wants to merge 3 commits into
mainfrom
lilydoar/throughput-original-start-v2

Conversation

@lilydoar

@lilydoar lilydoar commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Freeze the original throughput request and ordinary-versus-Update-with-Start choice across retries of a fresh strict iteration. Ordinary starts attach only to the history-verified original run; acknowledged run/update handles are retained, and failed closed executions are not replaced.

Review: As a single unit in stack order.

Why

Reconstructing actions and start mode on every iteration attempt can collide with a workflow whose start succeeded but whose response was lost. Reusing only its workflow ID can also redirect an update to a different execution after ID reuse.

Details worth reviewing

Existing resumed/IgnoreAlreadyStarted paths retain their legacy behavior; the new identity is in-process state and does not add durable recovery across activity/process reconstruction.

An Update-with-Start error before any returned run handle remains a strict failure with no replay. The public SDK cannot bind a reconstructed Update-with-Start to a known RunID; a stable UpdateID alone does not solve that uncertainty. This is scoped start safety, not complete FI qualification.

@lilydoar
lilydoar requested review from a team as code owners November 4, 2026 18:45
@lilydoar
lilydoar added this pull request to stack #540 November 4, 2026 18:45
@CLAassistant

CLAassistant commented Nov 4, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@lilydoar
lilydoar force-pushed the lilydoar/throughput-original-start-v2 branch from 327af5d to 63b7db7 Compare November 4, 2026 18:54
Base automatically changed from lilydoar/retry-probe-timing-v2 to main November 4, 2026 21:16
@lilydoar
lilydoar force-pushed the lilydoar/throughput-original-start-v2 branch from 63b7db7 to 2f503f6 Compare November 4, 2026 21:16
@lilydoar
lilydoar force-pushed the lilydoar/throughput-original-start-v2 branch from 2f503f6 to b652590 Compare November 4, 2026 22:04
Comment thread loadgen/kitchen_sink_executor.go Resolved
Comment thread loadgen/kitchensink/original_start.go Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants