Repository navigation
chore(samples): sync the stream sample with temporalio/api#895 - #362
Merged
Merged
Conversation
The stream sample's WIT is the Stream service WIT of the protos PR. A directive that nexgen doesn't support yet stays a TODO comment, and the `body-t` alias stays `payload` until nexgen supports its type parameter. The protos and bindings are those of the PR. The sample gains the `request_id` helper that the create's source calls. It loses the owner helper, since a create no longer sends an owner.
1 of 3 tasks
dplyukhin
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR syncs the stream sample with the Stream service WIT and protos of temporalio/api#895, after its API review.
StreamRef, anid-conflict-policyand arequest-id.already-existsandstorage-corrupt, and three reasons get clearer names.Why?
The sample WIT is a copy of the WIT in temporalio/api#895, so it follows that PR.
How did you test it?
Link to a test plan if any -