Skip to content

chore(samples): sync the stream sample with temporalio/api#895 - #354

Merged
tconley1428 merged 1 commit into
mainfrom
moe/up/stream-sample-sync
Nov 4, 2026
Merged

tconley1428 merged 1 commit into
mainfrom
moe/up/stream-sample-sync

Conversation

@moetemp

@moetemp moetemp commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

What changed?

This PR syncs the stream sample with the Stream service WIT of temporalio/api#895 and its protos, as far as nexgen supports it today.

  • stream-ref is now stream-handle, and supersession is now stream-superseded, as in the API.
  • The WIT leaves out what nexgen can't generate yet:
    • type parameters on a resource, so body-t stays payload;
    • a source that reads definition, so the Workflow create takes the Stream id;
    • @nexus.api-omit targets=, so the client-only fields of append-records-request are omitted;
    • a nested source under a field-level flatten.
  • nexgen accepts the other new directives but doesn't act on them yet: @nexus.definition, @nexus.poll, @nexus.varargs, @nexus.unwrap, @nexus.result-field, @nexus.close, @nexus.error and the new flatten-in-api options.
  • The sample's support code gets the sources that the WIT mentions, in Python, TypeScript and .NET, and the tests use the new names.

Why?

The sample is the Stream service's real WIT, so a PR that adds one of these features shows its effect on it.

How did you test it?

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

cargo validate for Python, TypeScript and .NET, the Rust tests, and a regen that leaves no diff.

@moetemp moetemp added the skip-changelog No user-facing changelog fragment required label Nov 4, 2026
@moetemp
moetemp marked this pull request as ready for review November 4, 2026 01:06
@moetemp
moetemp requested a review from a team as a code owner November 4, 2026 01:06
@tconley1428
tconley1428 merged commit 9177545 into main Nov 4, 2026
5 of 6 checks passed
@tconley1428
tconley1428 deleted the moe/up/stream-sample-sync branch November 4, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No user-facing changelog fragment required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants