Repository navigation
chore(samples): sync the stream sample with temporalio/api#895 - #354
Merged
Merged
Conversation
tconley1428
approved these changes
Nov 4, 2026
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR syncs the stream sample with the Stream service WIT of temporalio/api#895 and its protos, as far as nexgen supports it today.
stream-refis nowstream-handle, andsupersessionis nowstream-superseded, as in the API.body-tstayspayload;definition, so the Workflow create takes the Stream id;@nexus.api-omit targets=, so the client-only fields ofappend-records-requestare omitted;@nexus.definition,@nexus.poll,@nexus.varargs,@nexus.unwrap,@nexus.result-field,@nexus.close,@nexus.errorand the newflatten-in-apioptions.Why?
The sample is the Stream service's real WIT, so a PR that adds one of these features shows its effect on it.
How did you test it?
Link to a test plan if any -
cargo validatefor Python, TypeScript and .NET, the Rust tests, and a regen that leaves no diff.