Repository navigation
chore: use same protobufjs installation - #956
Merged
Merged
Conversation
VegetarianOrc
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Use the exact protobufjs installation that
@temporalio/protouses via alink:dependency.Why?
Semi related to temporalio/sdk-typescript#2668, but we fail against linked SDK repos.
Could be fully avoided if we just inspected raw bytes instead of serializing them in the
json_protobuffeature, but we should make sure this is still possible.Showing up after #944 because of the same wildcard removal where we would just accidentally end up using the matching
protobufjsinstallation.Checklist
Closes
How was this tested:
Okay, actually tested this against my local SDK checkout so we hit the same path that TS SDK hits. Verified failure matched pre-fix and is resolved post fix.