Skip to content

chore: use same protobufjs installation - #956

Merged
chris-olszewski merged 1 commit into
mainfrom
olszewski/fix_ts_once_more
Nov 18, 2026
Merged

chris-olszewski merged 1 commit into
mainfrom
olszewski/fix_ts_once_more

Conversation

@chris-olszewski

@chris-olszewski chris-olszewski commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

What was changed

Use the exact protobufjs installation that @temporalio/proto uses via a link: dependency.

Why?

Semi related to temporalio/sdk-typescript#2668, but we fail against linked SDK repos.

Could be fully avoided if we just inspected raw bytes instead of serializing them in the json_protobuf feature, but we should make sure this is still possible.

Showing up after #944 because of the same wildcard removal where we would just accidentally end up using the matching protobufjs installation.

Checklist

  1. Closes

  2. How was this tested:

Okay, actually tested this against my local SDK checkout so we hit the same path that TS SDK hits. Verified failure matched pre-fix and is resolved post fix.

  1. Any docs updates needed?

@chris-olszewski
chris-olszewski requested review from a team as code owners November 18, 2026 20:06
@chris-olszewski
chris-olszewski enabled auto-merge (squash) November 18, 2026 20:42
@chris-olszewski
chris-olszewski merged commit 1829a3e into main Nov 18, 2026
52 of 53 checks passed
@chris-olszewski
chris-olszewski deleted the olszewski/fix_ts_once_more branch November 18, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants