Skip to content

Document Cloud Run Public Preview and combined SDK samples - #5292

Merged
lennessyy merged 17 commits into
mainfrom
cloud-run-otel-worker-id
Oct 19, 2026
Merged

lennessyy merged 17 commits into
mainfrom
cloud-run-otel-worker-id

Conversation

@lennessyy

@lennessyy lennessyy commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Cloud Run is in Public Preview, and the SDK sample PRs now combine Worker identity and OpenTelemetry setup. This updates the release banners and related prose for Cloud Run while preserving the AWS Lambda and Amazon Bedrock AgentCore Runtime release stages.

The Go, Java, Python, and .NET SDK guides now use the combined samples: four Worker setup snippets and three Collector configurations are refreshed through Snipsync from each repository's main branch. Java identity setup is now included in a source-managed snippet, and .NET uses the Cloud Run OpenTelemetry defaults helper. The production deployment examples follow the combined samples' connection and identity setup.

Validation

  • Production build passed.
  • CI-scoped Vale passed with no errors or warnings.
  • Snipsync rerun against the samples' main branches after the sample PRs merged.
  • Generated Markdown shows Public Preview for all seven Cloud Run SDK guides; AWS Lambda and AgentCore Runtime retain their existing stages.

@vercel

vercel Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
temporal-documentation Ready Ready Preview Oct 19, 2026 9:14pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

📖 Docs PR preview links

@lennessyy

lennessyy commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor Author

@claude review this (test)

@lennessyy
lennessyy marked this pull request as ready for review September 29, 2026 20:21
@lennessyy
lennessyy requested a review from a team as a code owner September 29, 2026 20:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6370d8cf36

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Additional findings (outside the current diff — GitHub can't attach inline comments there):

  • 🟡 docs/production-deployment/worker-deployments/serverless-workers/cloud-run/index.mdx — Readers get a blanket claim that now contradicts the code samples on the same page: line 32 says Cloud Run needs "no Cloud Run-specific handler or package and any Temporal SDK can run on a Worker Pool," but this diff adds CloudRunIdPlugin imports to the Python (line 80), Go (147), Java (265), and .NET (327) sample Worker code right below it. This summary sentence wasn't updated when the plugin imports were added, so it's now false for 4 of the 7 SDKs the page covers. Fix: scope the "no package" claim to the SDKs where it still holds (TypeScript, Ruby, Rust) or note that Python/Go/Java/.NET add the Cloud Run Id plugin package.

    Why this was flagged

    docs/production-deployment/.../cloud-run/index.mdx:32-33 states there is 'no Cloud Run-specific handler or package and any Temporal SDK can run on a Worker Pool.' The same diff then adds a CloudRunIdPlugin/CloudRunIDPlugin import to the Python, Go, Java, and .NET sample Worker code later in this exact file (lines 80, 147, 265, 327). A reader relying on the line-32 summary is told no extra package is ever needed, directly contradicting the examples on the same page. On the base branch this line was accurate since no sample imported a Cloud Run-specific package; the diff makes it false without updating it.

    Verification: normal — introduced contradiction. Line 32 of docs/production-deployment/.../cloud-run/index.mdx reads "Cloud Run runs a standard long-lived Worker, so there is no Cloud Run-specific handler or package and any Temporal SDK can run on a Worker Pool." (unchanged by the diff). This same diff adds Cloud-Run-specific package imports to the sample Worker code on this exact page: Python line 80 `from…

@lennessyy lennessyy changed the title Document Cloud Run OTel and Worker identity setup Document Cloud Run Public Preview and combined SDK samples Sep 30, 2026
Copilot AI balanced review requested due to automatic review settings October 19, 2026 20:59
@github-actions

Copy link
Copy Markdown
Contributor

Snipsync coverage

SDK code lines in docs/ that come from Snipsync: 17.6% → 17.7% (+0.1 pts), 6,682 of 37,753 lines.

Section Snipsync lines Inline lines Snipsync % Change
develop/dotnet 27 → 35 2,063 → 2,071 1.3% → 1.7% +0.4 pts
develop/go 1,559 → 1,578 2,474 → 2,492 38.7% → 38.8% +0.1 pts
develop/java 684 → 692 3,091 → 3,105 18.1% → 18.2% +0.1 pts
develop/python 1,737 → 1,747 2,875 → 2,888 37.7% → 37.7% ±0.0 pts
production-deployment 54 803 → 805 6.3% → 6.3% ±0.0 pts
All sections

All languages: 15.6% (7,108 of 45,447 lines).

Section Snipsync lines Inline lines Snipsync %
design-patterns 0 7,834 0.0%
develop/python 1,747 2,888 37.7%
guides 34 4,494 0.8%
develop/go 1,578 2,492 38.8%
develop/typescript 1,948 2,026 49.0%
develop/java 692 3,105 18.2%
develop/dotnet 35 2,071 1.7%
develop/rust 0 1,257 0.0%
develop/php 30 1,144 2.6%
develop/ruby 21 1,145 1.8%
develop 484 604 44.5%
production-deployment 54 805 6.3%
encyclopedia 0 837 0.0%
develop/worker-performance 48 177 21.3%
cloud 0 127 0.0%
references 0 48 0.0%
best-practices 11 17 39.3%
Language Snipsync lines Inline lines Snipsync %
Python 1,890 8,968 17.4%
Go 1,718 5,593 23.5%
TypeScript 2,089 4,510 31.7%
Java 777 5,649 12.1%
C# 110 2,533 4.2%
Ruby 68 1,326 4.9%
Rust 0 1,324 0.0%
PHP 30 1,168 2.5%
Snipsync origin Lines
temporalio/samples-typescript 1,799
temporalio/samples-python 1,729
temporalio/features 835
temporalio/documentation-sdk-code-examples 828
temporalio/samples-go 712
temporalio/samples-java 576
temporalio/sdk-typescript 119
unattributed 35
temporalio/samples-php 30
temporalio/reference-app-orders-go 11
temporalio/samples-dotnet 8

Compared with bf01b4b. Counts non-blank lines in fenced code blocks tagged with an SDK language. Hand-written code isn't compiled anywhere; code Snipsync pulls from a sample repository is built in that repository's CI. See UTILITIES.md.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The examples depend on pending upstream sample PRs whose final APIs and main-branch synchronization need human confirmation.

No open issues 🎉

What changed in this PR

Updates Cloud Run documentation for Public Preview with combined Worker identity and OpenTelemetry samples.

Changes:

  • Adds combined SDK setup examples and Collector configurations.
  • Aligns production deployment examples with Cloud Run identity plugins.
  • Documents telemetry shutdown and metadata requirements.
File Description
docs/​production-deployment/​worker-deployments/​serverless-workers/​cloud-run/​index.mdx Updates connection setup and Worker identity examples.
docs/​develop/​python/​workers/​serverless-workers/​cloud-run.mdx Adds combined plugins and Collector configuration.
docs/​develop/​java/​workers/​serverless-workers/​cloud-run.mdx Adds combined plugins and Collector configuration.
docs/​develop/​go/​workers/​serverless-workers/​cloud-run.mdx Adds combined plugins and Collector configuration.
docs/​develop/​dotnet/​workers/​serverless-workers/​cloud-run.mdx Adds OpenTelemetry defaults and identity setup.

Review effort: Balanced

The combined sample PRs merged and their gcp-cloud-run branches were deleted.
Rerun Snipsync against main and switch the complete-example links to main.
@lennessyy
lennessyy merged commit 9dbb61b into main Oct 19, 2026
18 checks passed
@lennessyy
lennessyy deleted the cloud-run-otel-worker-id branch October 19, 2026 21:27

This branch was successfully deployed

1 active deployment
Preview — bab6caaf Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants