Skip to content

Show server defaults for unset encryption validation metadata - #127

Closed
tempurabrent wants to merge 1 commit into
mainfrom
brent/eve-get-show-defaults
Closed

tempurabrent wants to merge 1 commit into
mainfrom
brent/eve-get-show-defaults

Conversation

@tempurabrent

@tempurabrent tempurabrent commented Nov 9, 2026 •

Copy link
Copy Markdown

Summary

  • temporal cloud namespace encryption-validation get now shows the defaults the server applies when the metadata key or values are unset (metadata-key=encoding, metadata-values=[binary/encrypted], per the cloud-api EncryptionValidationSpec docs), instead of empty fields.
  • The fetched spec is cloned before defaults are filled in, so the response isn't mutated.
  • Updated the command description in commands.yml and regenerated commands.gen.go.

Testing

  • Added unit tests UnsetMetadataShowsDefaults and UnsetMetadataKeyOnly; the encryption-validation tests pass.
  • TestErrorsAreNotLogMessages and TestErrorsAreNotLogMessagesJSON fail locally on a clean main tree too (they depend on the local environment), so this change didn't cause those failures.

🤖 Generated with Claude Code


Note

Low Risk
Read-only display change in an experimental CLI command with tests; no write path or auth impact.

Overview
temporal cloud namespace encryption-validation get now displays the effective metadata settings when the API leaves metadata-key or metadata-values empty, using the server defaults (encoding and binary/encrypted).

The getter clones the spec before filling defaults so the fetched namespace object is not mutated. CLI help in commands.yml / commands.gen.go documents this behavior, and new tests cover fully and partially unset metadata.

Reviewed by Cursor Bugbot for commit 4621797. Configure here.

`namespace encryption-validation get` now fills in the server-applied
defaults (metadata-key=encoding, metadata-values=[binary/encrypted]) when
the stored spec leaves them unset, so the output reflects what is enforced.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@tempurabrent
tempurabrent requested a review from a team as a code owner November 9, 2026 20:25
@CLAassistant

CLAassistant commented Nov 9, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the changes that make encryption-validation metadata defaults visible.

No open issues 🎉

What changed in this PR

This PR improves the Temporal Cloud CLI’s encryption-validation output by making server defaults visible for unset metadata fields.

Changes:

  • Default metadata display: encoding for an unset key and binary/encrypted for unset values.
  • Response preservation through cloning before default substitution.
  • Updated CLI help and tests for fully unset metadata and an unset key with custom values.
File Description
temporalcloudcli/​commands.yml Help text documenting default metadata display.
temporalcloudcli/​commands.namespace.encryption_validation.go Default substitution on a cloned encryption-validation spec.
temporalcloudcli/​commands.namespace.encryption_validation_test.go Coverage for fully and partially unset metadata.
temporalcloudcli/​commands.gen.go Regenerated command help matching the YAML definition.

Review effort: Balanced

@tempurabrent
tempurabrent deleted the brent/eve-get-show-defaults branch November 9, 2026 21:07

This branch was successfully deployed

1 active deployment
integration — 46217976 Deployed Nov 9, 2026 by tempurabrent via Integration tests #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants