Repository navigation
Show server defaults for unset encryption validation metadata - #127
Closed
tempurabrent wants to merge 1 commit into
Closed
tempurabrent wants to merge 1 commit into
tempurabrent wants to merge 1 commit into
Conversation
`namespace encryption-validation get` now fills in the server-applied defaults (metadata-key=encoding, metadata-values=[binary/encrypted]) when the stored spec leaves them unset, so the output reflects what is enforced. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changes that make encryption-validation metadata defaults visible.
No open issues 🎉
What changed in this PR
This PR improves the Temporal Cloud CLI’s encryption-validation output by making server defaults visible for unset metadata fields.
Changes:
- Default metadata display:
encodingfor an unset key andbinary/encryptedfor unset values. - Response preservation through cloning before default substitution.
- Updated CLI help and tests for fully unset metadata and an unset key with custom values.
| File | Description |
|---|---|
temporalcloudcli/commands.yml |
Help text documenting default metadata display. |
temporalcloudcli/commands.namespace.encryption_validation.go |
Default substitution on a cloned encryption-validation spec. |
temporalcloudcli/commands.namespace.encryption_validation_test.go |
Coverage for fully and partially unset metadata. |
temporalcloudcli/commands.gen.go |
Regenerated command help matching the YAML definition. |
Review effort: Balanced
khisakuni
approved these changes
Nov 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
temporal cloud namespace encryption-validation getnow shows the defaults the server applies when the metadata key or values are unset (metadata-key=encoding,metadata-values=[binary/encrypted], per the cloud-apiEncryptionValidationSpecdocs), instead of empty fields.commands.ymland regeneratedcommands.gen.go.Testing
UnsetMetadataShowsDefaultsandUnsetMetadataKeyOnly; the encryption-validation tests pass.TestErrorsAreNotLogMessagesandTestErrorsAreNotLogMessagesJSONfail locally on a cleanmaintree too (they depend on the local environment), so this change didn't cause those failures.🤖 Generated with Claude Code
Note
Low Risk
Read-only display change in an experimental CLI command with tests; no write path or auth impact.
Overview
temporal cloud namespace encryption-validation getnow displays the effective metadata settings when the API leavesmetadata-keyormetadata-valuesempty, using the server defaults (encodingandbinary/encrypted).The getter clones the spec before filling defaults so the fetched namespace object is not mutated. CLI help in
commands.yml/commands.gen.godocuments this behavior, and new tests cover fully and partially unset metadata.Reviewed by Cursor Bugbot for commit 4621797. Configure here.