Skip to content

Clarify that target_pollers is 0 only when unreported - #904

Closed
veeral-patel wants to merge 1 commit into
mainfrom
vpatel/target-pollers-comment
Closed

veeral-patel wants to merge 1 commit into
mainfrom
vpatel/target-pollers-comment

Conversation

@veeral-patel

Copy link
Copy Markdown
Contributor

What changed

Doc-only reword of the target_pollers comments on PollerPoolInfo (temporal/api/taskqueue/v1/message.proto) and WorkerPollerInfo (temporal/api/worker/v1/message.proto).

Both previously said:

0 if unknown, such as a poller pool of fixed size.

Why it's wrong

The SDKs are being changed so that a fixed-size poller pool reports its configured poller count in target_pollers instead of reporting nothing. A fixed-size pool is therefore no longer an example of an unknown value -- it's a known one. After that change, 0/absent means only that the SDK does not report a target (for example, an older SDK).

The WorkerPollerInfo comment also now points at is_autoscaling, which is what a consumer uses to tell an autoscaling pool from a fixed one.

Scope

Documentation only -- no field numbers, types, or fields changed, and no wire impact. The regenerated openapi/openapiv2.json and openapi/openapiv3.yaml are included because the WorkerPollerInfo comment is embedded in them (the heartbeat is reachable over the HTTP API via RecordWorkerHeartbeat). PollerPoolInfo has no HTTP binding and does not appear in the specs.

The fields themselves were introduced in #887 and #902.

@veeral-patel
veeral-patel requested review from a team November 6, 2026 03:42
@veeral-patel

Copy link
Copy Markdown
Contributor Author

Closing in favor of: #903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant