Repository navigation
Clarify that target_pollers is 0 only when unreported - #904
Closed
veeral-patel wants to merge 1 commit into
Closed
veeral-patel wants to merge 1 commit into
veeral-patel wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing in favor of: #903 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Doc-only reword of the
target_pollerscomments onPollerPoolInfo(temporal/api/taskqueue/v1/message.proto) andWorkerPollerInfo(temporal/api/worker/v1/message.proto).Both previously said:
Why it's wrong
The SDKs are being changed so that a fixed-size poller pool reports its configured poller count in
target_pollersinstead of reporting nothing. A fixed-size pool is therefore no longer an example of an unknown value -- it's a known one. After that change,0/absent means only that the SDK does not report a target (for example, an older SDK).The
WorkerPollerInfocomment also now points atis_autoscaling, which is what a consumer uses to tell an autoscaling pool from a fixed one.Scope
Documentation only -- no field numbers, types, or fields changed, and no wire impact. The regenerated
openapi/openapiv2.jsonandopenapi/openapiv3.yamlare included because theWorkerPollerInfocomment is embedded in them (the heartbeat is reachable over the HTTP API viaRecordWorkerHeartbeat).PollerPoolInfohas no HTTP binding and does not appear in the specs.The fields themselves were introduced in #887 and #902.