Exclude private system apps by default on new profiles - #12
Merged
Merged
Conversation
Signed-off-by: Nikolai Berezovskii <nikolai@brzv.sk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
A new profile excludes Apple Passwords and Keychain Access from clipboard capture by default. Existing profiles, intentionally empty exclusion lists, and custom lists keep their current behavior. The new defaults persist immediately so removing them stays respected across launches. Corrupt saved values are not overwritten.
Independent PR; no merge dependencies.
How you tested it
Compiled and ran
Scripts/Tests/PrivateAppDefaultsTests.swifttogether with the realCopy/Settings/SettingsStore.swift: new profile, persistence, explicit removal, empty/custom lists, onboarded profile and malformed stored data all passed. Uses temporary UserDefaults suites only.Command:
swiftc -parse-as-library Copy/Settings/SettingsStore.swift Scripts/Tests/PrivateAppDefaultsTests.swift -o /tmp/copy-private-defaults-tests && /tmp/copy-private-defaults-tests.Xcode Debug build and
git diff --checkpassed.Every commit is signed off.
All three SPM pins are preserved.