Conversation
Signed-off-by: Nikolai Berezovskii <nikolai@brzv.sk>
Owner
|
Merged as 198b42d. I rebased this onto current main and resolved the ItemCardView conflict, which was your new favicon and title layout replacing the old if/else branch. Took your version, kept the font change from #8 and the favorites changes from #15 that had landed in the same file. Closing because the rebase changed the SHAs, so GitHub can't match it back to this branch. The work is in. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Link cards put the page title next to the favicon and give the URL more body lines, bounded in both regular and compact cards. Already-visible favicons refresh when metadata arrives; an earlier missing-icon lookup cannot erase a later successful result.
Visible older links fetch missing metadata when previews are enabled, including when the setting changes while the shelf is open. Capture and backfill share one fetcher and its in-flight deduplication. Disabling previews prevents new backfill requests.
Independent PR; no merge dependencies. Typography remains the current upstream font so the system-font PR can be considered separately.
How you tested it
Xcode Debug build passed with pinned dependencies and signing disabled.
Reviewed the existing disabled/resolved/in-flight guards, asynchronous favicon callbacks, and bounded regular/compact card layout;
git diff --checkpassed.No engine changes. Live visual/network interaction verification is not claimed because UI automation cannot attach to the isolated demo app.
Every commit is signed off.
All three SPM pins are preserved.