Reorder pinboards by dragging their tabs - #10
Merged
Merged
Conversation
Signed-off-by: Nikolai Berezovskii <nikolai@brzv.sk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Drag a pinboard tab before or after another tab to persist its position. An insertion marker shows the destination, and History stays first. Existing pinboard colors, emoji, symbols, editing and card-filing drops are preserved. Tab payloads use a distinct app-local type and move operation.
Independent PR; no merge dependencies.
How you tested it
All 189 CopyCore tests passed, including before/after moves, an existing-gap no-op, unknown IDs and self-drops.
Xcode Debug build passed with pinned dependencies and signing disabled.
Reviewed transactional ordering and the separate card/tab drop paths;
git diff --checkpassed.Live drag verification is not claimed: local UI automation cannot attach to the isolated demo app.
Every commit is signed off.
Engine changes include tests.
All three SPM pins are preserved.