ci(release-monitor): pin the onboarding commit surface via add-paths - #115
Merged
Merged
Conversation
create-pull-request commits the whole dirty tree by default. The 4.0.7 onboarding (#110) rode in with the runner's .bundle/config (bundler-cache writes a runner-local BUNDLE_PATH) and the monitor's own monitor-result.json summary — neither belongs on main (the 3.3.8 onboarding, #17, carried only versions.yml + patches/). Pin add-paths to exactly the onboarding surface: the version catalog and the patch tree. New per-version partition/overlay files land under patches/, so seeding stays covered; any future runner junk stays out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
add-pathson the release monitor'screate-pull-requeststep to exactly the onboarding surface:versions.yml+patches/.Why
create-pull-requestcommits the whole dirty tree by default. The 4.0.7 onboarding (#110) rode in with:.bundle/config—bundler-cache: truewrites a runner-localBUNDLE_PATH(/home/runner/work/ruby/ruby/...)monitor-result.json— the monitor's own run summaryNeither belongs on main; the established shape (#17, ruby 3.3.8) is
versions.yml+patches/only. #110 was cleaned on its branch before merge; this stops the recurrence.New per-version partition/overlay files land under
patches/, so seeding/extending stays covered; any future runner junk stays out of the commit.Proof
versions.yml+patches/4.0/patch-4.0.yamlonly — merged asfee551e, full 44-version lint matrix green.create-pull-request@v7documentsadd-paths(newline-delimited).