Conversation
With this merged, I'll also close the old dependabot PRs 524, 526, and 527
Upgrade jest, ts-jest, and @types/jest to their 29.x lines and add jest-environment-jsdom (split out of Jest core in v28+), since ts-jest 27 caps its typescript peer dependency below 5.0. Also remove a stray untracked yarn.lock; npm is the authoritative package manager here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Verified npm run build (lint + webpack/ts-loader compile of all Samples-Typescript sources) and npm test both pass, on both the local default Node and Node v20.19.0. tslint runs cleanly against the TS 5.9 AST despite being unmaintained since 2019. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bcantoni
changed the title
There was a problem hiding this comment.
🟡 Changes recommended
Replace or remove the ineffective allowScripts configuration.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates development dependencies for vulnerability cleanup, TypeScript 5.9, and newer Jest tooling.
Changes:
- Upgrades TypeScript, Jest, ts-jest, and related typings.
- Adds
jest-environment-jsdom. - Adds install-script configuration metadata.
File summaries
| File | Summary |
|---|---|
package.json |
Updates development tooling, but allowScripts is not recognized and does not configure script execution as intended. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Do it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this merged, I'll also close the old dependabot PRs 524, 526, and 527.
The first push had build failures, so I also updated jest and typescript (to 5.9). The tslint still works, but as a future improvement, Claude suggested we should migrate to eslint because tslint is unmaintained since 2019.