Harden EVM transaction fee handling by sidhujag · Pull Request #238 · syscoin/sysweb3

sidhujag · 2026-07-05T04:43:20Z

Summary

Normalize serialized BigNumber fee/gas fields before ethers v6 token transaction population.
Fill missing gas and fee fields before hardware-wallet EVM signing paths.
Preserve ERC721 token IDs beyond JS safe integer range and return gas limits in gas units.

Test plan

yarn test packages/sysweb3-keyring/test/unit/transactions/ethereum-transactions.spec.ts --runInBand --forceExit
yarn type-check (packages/sysweb3-keyring)

Made with Cursor

This reverts commit a8844aa.

This reverts commit f5fcd45.

This reverts commit af2efc1.

This reverts commit b068f1c.

- Add AsyncMutex to vault storage preventing data corruption from concurrent operations

update version

Co-authored-by: Cursor <cursoragent@cursor.com>

Migrate EVM signing to ethers v6

Cache short-lived fee discovery, avoid full fee lookup for gas price, and construct EVM providers with the selected chain so ethers does not re-detect static RPC networks.

Use ethers v6 package exports for the local compatibility layer while preserving the CommonJS package build with narrow type declarations.

Avoid root ethers runtime imports in network and utils packages so downstream bundles can resolve narrower ethers v6 entrypoints.

This reverts commit b72afb5.

This reverts commit b53a4c3.

This reverts commit 822771a.

This reverts commit 087d2e1.

This reverts commit d8894a8.

This reverts commit 2145fdf.

Co-authored-by: Cursor <cursoragent@cursor.com>

perf(keyring): reduce provider RPC fanout

Normalize serialized fee fields before ethers v6 token calls and fill missing gas data before hardware signing so wallet transaction paths remain compatible after background serialization. Co-authored-by: Cursor <cursoragent@cursor.com>

This reverts commit 231bba4.

Normalize serialized fee fields before ethers v6 token calls and fill missing gas data before hardware signing so wallet transaction paths remain compatible after background serialization. Co-authored-by: Cursor <cursoragent@cursor.com>

sidhujag · 2026-07-05T04:45:11Z

Closing: this PR was opened against the wrong repository. Re-opening against sidhujag/sysweb3.

jagdeep sidhu added 30 commits July 25, 2025 16:39

update to @syscoin package domain

5a13086

update to @sidhujag namespace

a41a00d

export getChainById

c6899ed

update keyring

269b5a9

update utils

a867823

Update package.json

880616d

update keyring

46319cd

fix tests

4558378

rm deprecated Descriptor usage in ledger bitcoin and rm unused package

4158ef8

move ethers to peer dep

b068f1c

proper peer dep management

af2efc1

update utils

f5fcd45

update dep

a8844aa

Revert "update dep"

ab02da6

This reverts commit a8844aa.

Revert "update utils"

f78ea60

This reverts commit f5fcd45.

Revert "proper peer dep management"

89623f4

This reverts commit af2efc1.

Revert "move ethers to peer dep"

863d322

This reverts commit b068f1c.

stable dep

b205cab

finalize deps

9ad5e40

rm ISyscoinTransactionError

13b65a4

update node version for yml

359e2d9

rm tokens.json (not used)

e95ca49

update utils + remove rounding on getBalance

71a3330

add secure wrapper for crypto operations

9e2c7f5

fix: vault corruption

115ed2f

- Add AsyncMutex to vault storage preventing data corruption from concurrent operations

rev keyring

3c18dd9

update version

use readonly signers until actually signing

66edd8b

rm unused getsigner in trezor

7c07aa8

add address and amount checks on trezor type

78e0420

update packages from sjs lib update

7df680e

jagdeep sidhu and others added 28 commits July 4, 2026 13:22

Use super call for normalized provider requests

fb914b4

Co-authored-by: Cursor <cursoragent@cursor.com>

Restore provider call spy safely

222ede4

Co-authored-by: Cursor <cursoragent@cursor.com>

Wrap provider responses and zero base fees

ebefc63

Co-authored-by: Cursor <cursoragent@cursor.com>

Preserve ERC1155 balances exactly

66c28a9

Co-authored-by: Cursor <cursoragent@cursor.com>

Forward block tags for balance requests

adebc72

Co-authored-by: Cursor <cursoragent@cursor.com>

Resolve named EVM recipients locally

c3a0311

Co-authored-by: Cursor <cursoragent@cursor.com>

Reject unsafe numeric transaction values

260c470

Co-authored-by: Cursor <cursoragent@cursor.com>

update sjs lib

3f573b6

Merge pull request #9 from sidhujag/chore/ethers-v6-keyring-migration

2d40cb5

Migrate EVM signing to ethers v6

perf(keyring): reduce provider RPC fanout

2a96c7a

Cache short-lived fee discovery, avoid full fee lookup for gas price, and construct EVM providers with the selected chain so ethers does not re-detect static RPC networks.

chore(keyring): import ethers from exported subpaths

822771a

Use ethers v6 package exports for the local compatibility layer while preserving the CommonJS package build with narrow type declarations.

chore: use ethers package exports across runtime packages

b53a4c3

Avoid root ethers runtime imports in network and utils packages so downstream bundles can resolve narrower ethers v6 entrypoints.

keyring v1.0.604

b72afb5

Revert "keyring v1.0.604"

2145fdf

This reverts commit b72afb5.

Revert "chore: use ethers package exports across runtime packages"

d8894a8

This reverts commit b53a4c3.

Revert "chore(keyring): import ethers from exported subpaths"

087d2e1

This reverts commit 822771a.

Reapply "chore(keyring): import ethers from exported subpaths"

d92ac5e

This reverts commit 087d2e1.

Reapply "chore: use ethers package exports across runtime packages"

149ac33

This reverts commit d8894a8.

Reapply "keyring v1.0.604"

6d1cc40

This reverts commit 2145fdf.

fix getAddress

7d43850

fix(keyring): verify static provider chain id

f8bb709

Co-authored-by: Cursor <cursoragent@cursor.com>

fix(keyring): refresh static provider chain check

7a03e2f

Co-authored-by: Cursor <cursoragent@cursor.com>

fix(keyring): update local signer provider test doubles

26dad76

Co-authored-by: Cursor <cursoragent@cursor.com>

Merge pull request #10 from sidhujag/perf/provider-rpc-call-reduction

1649179

perf(keyring): reduce provider RPC fanout

Update package.json

4ef7dab

fix(keyring): harden EVM transaction fee handling

231bba4

Normalize serialized fee fields before ethers v6 token calls and fill missing gas data before hardware signing so wallet transaction paths remain compatible after background serialization. Co-authored-by: Cursor <cursoragent@cursor.com>

Revert "fix(keyring): harden EVM transaction fee handling"

bd12e9e

This reverts commit 231bba4.

fix(keyring): harden EVM transaction fee handling

8cb2515

Normalize serialized fee fields before ethers v6 token calls and fill missing gas data before hardware signing so wallet transaction paths remain compatible after background serialization. Co-authored-by: Cursor <cursoragent@cursor.com>

sidhujag closed this Jul 5, 2026

Navigation Menu

Repository navigation

Harden EVM transaction fee handling - #238

Harden EVM transaction fee handling#238
sidhujag wants to merge 193 commits into
syscoin:mainfrom
sidhujag:fix/evm-tx-v6-boundaries

sidhujag commented Jul 5, 2026

Uh oh!

sidhujag commented Jul 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sidhujag commented Jul 5, 2026

Summary

Test plan

Uh oh!

sidhujag commented Jul 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants