Repository navigation
Conversation
added 30 commits
July 25, 2025 16:39
xpub will be missing for some hw wallets potentially so set evm signer and just log a warning
This reverts commit e902bb1.
Preserve BIP84 public key versions for imported extended accounts and enrich Syscoin PSBT paths so imported zpub/vpub accounts can sign reliably. Remove zkSync-specific EVM transaction paths now that zkTanenbaum uses standard EVM handling. Co-authored-by: Cursor <cursoragent@cursor.com>
Fix imported zpub signing and remove zkSync handling
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Share duplicate-address detection across keyring account creation paths so imported and hardware accounts cannot duplicate existing passkey smart accounts. Co-authored-by: Cursor <cursoragent@cursor.com>
feat(keyring): add passkey smart account metadata
Keep passkey sponsor metadata aligned with the on-chain sponsor URL field and remove the stale URL hash property. Co-authored-by: Cursor <cursoragent@cursor.com>
- Add in-flight deduplication for `tokens=used&details=tokens` xpub fetches shared by getAddress/pubkey/path derivation and PSBT path enrichment (no TTL: derivation always sees fresh indexes once a request settles) - Cache getRecommendedFee per explorer URL for 60s (fee estimation was refetched on every send-screen change) - Cache txUtils.getRawTransaction responses for 60s with in-flight dedup; failures and null (not-yet-indexed) responses are never cached Co-authored-by: Cursor <cursoragent@cursor.com>
perf(keyring,utils): reduce Blockbook round trips in UTXO flows
…r errors The custom fetch-based send/sendBatch overrides threw plain Error(json.error.message), discarding json.error.data. Custom contract errors (e.g. ERC-7579 module reverts) became undecodable downstream: consumers only ever saw "execution reverted". Stock ethers v5 attaches code/data to JSON-RPC errors; restore that behavior so checkError/ spelunk and wallet error mapping can decode revert reasons again. Bumps @sidhujag/sysweb3-keyring to 1.0.593. Co-authored-by: Cursor <cursoragent@cursor.com>
fix(keyring): preserve JSON-RPC error code and revert data on provider errors
Co-authored-by: Cursor <cursoragent@cursor.com>
feat(keyring): Add SLH-DSA setup secret support
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…floor fix(keyring): avoid default gas limit floor
Replace ethers v5 package usage with ethers v6 boundaries so local and hardware EVM signing use maintained transaction handling while preserving app-facing value shapes. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
Closing: opened against the wrong repository. Re-opening against sidhujag/sysweb3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
packages/sysweb3-keyring:yarn type-checksysweb3:yarn test packages/sysweb3-keyring/test/unit/transactions/evm-local-signer.spec.ts --runInBandsysweb3: focused Ledger suite passed during migration after updating v6-specific error assertions.Made with Cursor