Skip to content

Add GitHub Actions workflow for Python application - #630

Closed
Kelleretoro wants to merge 1 commit into
sudoHG:mainfrom
Kelleretoro:main
Closed

Kelleretoro wants to merge 1 commit into
sudoHG:mainfrom
Kelleretoro:main

Conversation

@Kelleretoro

@Kelleretoro Kelleretoro commented Oct 27, 2026 •

Copy link
Copy Markdown

This workflow installs Python dependencies, runs linting with flake8, and executes tests using pytest.

Summary

Linked issue:

What changed

What deliberately did not change

Verification

Run on the final commit. Paste the result, and report failures with their output.

Command Result
scripts/check_all.sh
Unit tests, iOS (scripts/check_all.sh --with-unit-tests --ios-destination '<dest>' --tvos-destination '<dest>' --output-dir '<outside-repo>' or the full run_offline_unit_tests.py command in CONTRIBUTING.md)
Unit tests, tvOS (same check_all.sh --with-unit-tests command, or run_offline_unit_tests.py --platform tvos with --destination, --derived-data-path, and --result-bundle-path)
Other (UI / E2E suites, manual checks)

Failures that already existed before this change:

UI changes (skip if none)

  • Before and after screenshots of the changed screen, same device and settings (attached below)
  • Checked iPhone and iPad, light and dark mode, large Dynamic Type
  • tvOS: default focus, remote navigation, Select and Back, focus scaling
  • Screenshots contain no private photos, faces, server addresses or credentials
Before After

Localization (skip if no strings changed)

  • Every new or changed string has all locales (source en, plus zh-Hans, zh-Hant-HK, zh-Hant-TW, es, ja)
  • python3 scripts/validate_localization_catalog.py prints status=PASS

Checklist

  • Tests only where docs/TESTING.md section 0 calls for them, written first; each new test names the failure it guards against
  • iOS and tvOS both build; platform code is in the platform directories
  • No new third-party dependency (or it was agreed in the linked issue)
  • No secrets, env.xcconfig, .xcresult bundles or private data committed
  • Docs updated if behavior, commands, layout or privacy changed
  • AI-assisted: I read the diff and take responsibility for it
  • I agree to the Contribution license

Not verified

Risks

This workflow installs Python dependencies, runs linting with flake8, and executes tests using pytest.
@luoji-bot

luoji-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

Thanks, but this repository already runs its own CI and does not use a generic Python workflow. Closing.

@sudoHG sudoHG closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants