Skip to content

Don't present an answered delivery check as a banner while the iPhone app is in front #361

Open

Description

@sudoHG

Goal

While the iPhone app is in front, a notification for a delivery check the extension verified and answered is not presented as a banner and makes no sound. Every other notification, verified or not, is presented as today.

Context

Scope

May change:

  • iOS/AskKeyiOSNotificationService/Sources/ (mark the content it delivers for .answeredDeliveryCheck, for example with a dedicated category identifier)
  • iOS/AskKeyiOSKit/App/AskKeyAppDelegate.swift (userNotificationCenter(_:willPresent:): no banner or sound for that mark; list only, or nothing)
  • Tests for both targets

Must not change: how any other notification is presented, the extension's verification, the CloudKit subscription's notification info except as needed below.

Security

The app must be able to trust the mark. Only the extension sets it, and only after it verified and answered the delivery check. Content that reaches the app without passing through the extension, such as a timed-out extension where iOS shows the original payload, must never carry it. Check what the subscription's notification info puts in the original payload, and make sure the mark cannot come from there.

Acceptance

bash scripts/build-ios.sh test
python3 scripts/check_hygiene.py
  1. A verified, answered delivery check is not presented as a banner in front, with a test.
  2. A request notification, a generic notification and a delivery check the extension could not answer are still presented with banner, list and sound, with tests.
  3. The mark cannot appear on content the extension did not produce, with a test or a documented reason.
  4. All four CI jobs are green.

Blocked by

#346

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestready-for-agentFully specified; an agent may claim it

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions