Skip to content

Use the maintainer's wording for the Mac approval card footer and drop the Esc hint #356

Closed

Description

@sudoHG

Goal

The Mac approval panel's footer uses the maintainer's new wording (2026-11-16, replacing #344 decision 6's strings) and no longer shows "Esc to decide later". Esc still decides later.

Wording

The Simplified Chinese is the maintainer's and is fixed word for word (spaces between Chinese and Latin letters or digits follow the catalog's existing style).

State 简体中文 English
An eligible request waits for its 20-second send (today's "iPhone can decide in 18 s") 18 秒后将把审批请求发到 iPhone This request will be sent to iPhone in 18 s
A saved copy is still outstanding (today's "Also on iPhone · Expires in 4:39") 审批请求将于 4:39 后失效 This request expires in 4:39
Every other case, including no paired iPhone (today's "Expires in 4:59") 审批请求将于 4:59 后失效 This request expires in 4:59

The number still counts down once a second, as #350 built. When each state applies does not change.

Context

Scope

May change:

  • Sources/AskKeyAppKit/App/FrozenAgentApprovalPrompt.swift, Sources/AskKeyAppKit/App/RemoteApprovalPanelState.swift
  • Sources/AskKeyAppKit/Resources/Localizable.xcstrings (new keys; remove keys left unused)
  • Tests: Tests/AskKeyAppTests/RemoteApprovalFooterTests.swift, RemoteApprovalFooterHintTests.swift, ApprovalPromptContentTests.swift, RemoteApprovalRenderTests.swift, and Tests/AskKeyE2ETests/ScreenshotE2ETests.swift (it waits for "Esc to decide later")
  • docs/adr/0014-remote-approval.md → "Amendment: iPhone history, tabs and the Mac card hint (Amend ADR 0014 for the iPhone's request history, tabbed home and the Mac card's iPhone hint #345)" → Mac card hint: the strings, and the Why sentence that no longer matches

Must not change:

  • When or whether requests are sent; the card's front and Details; the pending-request list; the pairing sheet.
  • The website's demo card (site/, site-src/): it shows the released app and is updated at the next release.

Acceptance

swift build
swift test --filter AskKeyAppTests
python3 scripts/check_hygiene.py
  1. The footer shows the three strings above in both languages, with the countdown ticking as before.
  2. No "Esc to decide later" text remains on the panel. Pressing Esc still closes the panel and leaves the request pending, with a test.
  3. VoiceOver still offers deciding later on the panel, labeled in both languages.
  4. Renders in both languages through the real panel: before the send at about 18 s, after the send, and no approver. Every footer fits on one line in Chinese; English may wrap without moving the buttons.
  5. All four CI jobs are green, basic-ui-flows included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestready-for-agentFully specified; an agent may claim it

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions