Repository navigation
Closed
Labels
enhancementNew feature or requestNew feature or requestready-for-agentFully specified; an agent may claim itFully specified; an agent may claim it
Description
Goal
The Mac approval panel's footer uses the maintainer's new wording (2026-11-16, replacing #344 decision 6's strings) and no longer shows "Esc to decide later". Esc still decides later.
Wording
The Simplified Chinese is the maintainer's and is fixed word for word (spaces between Chinese and Latin letters or digits follow the catalog's existing style).
| State | 简体中文 | English |
|---|---|---|
| An eligible request waits for its 20-second send (today's "iPhone can decide in 18 s") | 18 秒后将把审批请求发到 iPhone | This request will be sent to iPhone in 18 s |
| A saved copy is still outstanding (today's "Also on iPhone · Expires in 4:39") | 审批请求将于 4:39 后失效 | This request expires in 4:39 |
| Every other case, including no paired iPhone (today's "Expires in 4:59") | 审批请求将于 4:59 后失效 | This request expires in 4:59 |
The number still counts down once a second, as #350 built. When each state applies does not change.
Context
- Tell the Mac approval card when an unanswered request goes to the iPhone #350 (PR Tell the Mac approval card when a request goes to the iPhone #355, merged c21c0bb) built the hint. The footer is
footeranddecideLaterButtoninSources/AskKeyAppKit/App/FrozenAgentApprovalPrompt.swift; the text comes fromRemoteApprovalFooterinSources/AskKeyAppKit/App/RemoteApprovalPanelState.swift. - Today the Esc shortcut is attached to the visible "Esc to decide later" button (
.keyboardShortcut(.cancelAction)), and VoiceOver reads the footer as one sentence whose action decides later. "Expires in %@"is also used by the pending-request list and the pairing sheet. Those must not change, so the footer gets its own keys.
Scope
May change:
Sources/AskKeyAppKit/App/FrozenAgentApprovalPrompt.swift,Sources/AskKeyAppKit/App/RemoteApprovalPanelState.swiftSources/AskKeyAppKit/Resources/Localizable.xcstrings(new keys; remove keys left unused)- Tests:
Tests/AskKeyAppTests/RemoteApprovalFooterTests.swift,RemoteApprovalFooterHintTests.swift,ApprovalPromptContentTests.swift,RemoteApprovalRenderTests.swift, andTests/AskKeyE2ETests/ScreenshotE2ETests.swift(it waits for "Esc to decide later") docs/adr/0014-remote-approval.md→ "Amendment: iPhone history, tabs and the Mac card hint (Amend ADR 0014 for the iPhone's request history, tabbed home and the Mac card's iPhone hint #345)" → Mac card hint: the strings, and the Why sentence that no longer matches
Must not change:
- When or whether requests are sent; the card's front and Details; the pending-request list; the pairing sheet.
- The website's demo card (
site/,site-src/): it shows the released app and is updated at the next release.
Acceptance
swift build
swift test --filter AskKeyAppTests
python3 scripts/check_hygiene.py- The footer shows the three strings above in both languages, with the countdown ticking as before.
- No "Esc to decide later" text remains on the panel. Pressing Esc still closes the panel and leaves the request pending, with a test.
- VoiceOver still offers deciding later on the panel, labeled in both languages.
- Renders in both languages through the real panel: before the send at about 18 s, after the send, and no approver. Every footer fits on one line in Chinese; English may wrap without moving the buttons.
- All four CI jobs are green,
basic-ui-flowsincluded.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestready-for-agentFully specified; an agent may claim itFully specified; an agent may claim it
Activity
Use the maintainer's wording for the approval card footer and drop th…