Repository navigation
Add note that .x files are trusted inputs - #232
Merged
Merged
Conversation
leighmcculloch
requested review from
dmkozh
and
a balanced review from Copilot
August 17, 2026 03:09
There was a problem hiding this comment.
Pull request overview
Documents that .x files are trusted inputs and generators do not prevent injection.
Changes:
- Adds a security warning to the README.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmkozh
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add note that the .x files are trusted inputs.
Why
This was implied by the use cases of the tooling, Stellar Protocol .x files, but not stated explicitly. The tooling is intended for use with .x files that the user has self authored or trusts and as such the tooling does not and won't prevent all forms of escape or injection that may exist in a third party .x file.
Eventually the code generators will be moved out of this repo, as they are unmaintained here, but until then this warning can serve to make this more explicit.