Skip to content

Add note that .x files are trusted inputs - #232

Merged
leighmcculloch merged 1 commit into
masterfrom
leighmcculloch-patch-1
Aug 17, 2026
Merged

leighmcculloch merged 1 commit into
masterfrom
leighmcculloch-patch-1

Conversation

@leighmcculloch

Copy link
Copy Markdown
Member

What

Add note that the .x files are trusted inputs.

Why

This was implied by the use cases of the tooling, Stellar Protocol .x files, but not stated explicitly. The tooling is intended for use with .x files that the user has self authored or trusts and as such the tooling does not and won't prevent all forms of escape or injection that may exist in a third party .x file.

Eventually the code generators will be moved out of this repo, as they are unmaintained here, but until then this warning can serve to make this more explicit.

@leighmcculloch
leighmcculloch requested review from dmkozh and a balanced review from Copilot August 17, 2026 03:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents that .x files are trusted inputs and generators do not prevent injection.

Changes:

  • Adds a security warning to the README.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md Resolved
@leighmcculloch
leighmcculloch merged commit d54959f into master Aug 17, 2026
13 checks passed
@leighmcculloch
leighmcculloch deleted the leighmcculloch-patch-1 branch August 17, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants