Repository navigation
Conversation
Renames: - [backfill.bsb].num_workers -> workers - [service.preflight].worker_count -> workers - [ingestion].core_http_query_thread_pool_size -> core_http_query_workers Why: one idea had four spellings. [backfill].workers already used this one. Part of #1176. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renames: - [backfill.bsb] -> [backfill.download] - buffer_size -> prefetch_files - buffer_bytes -> prefetch_bytes Why: "bsb" is SDK jargon. buffer_size counts files but read like bytes. Part of #1176. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renames: - [service.preflight] -> [service.simulation] - simulation_memory_limit -> memory_limit Why: operators know the method as simulateTransaction. "Preflight" is the internal name. Unchanged: the preflight package, its metrics, v1's --preflight-* flags. Part of #1176. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renames: - captive_core_config -> core_config - captive_core_storage_path -> core_storage_path - stellar_core_binary_path -> core_binary_path Why: [ingestion] used three prefixes (core_, captive_core_, stellar_core_) for one process. Part of #1176. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renames: - [storage].default_data_dir -> data_dir Why: the key is required, so "default" was misleading. Part of #1176. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renames, on getTransactions, getLedgers, getEvents, queryEvents: - max_items_per_response -> max_page_limit - default_items_per_response -> default_page_limit Why: they cap and default the client's pagination.limit. Part of #1176. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renames:
- [storage].txhash_raw -> txhashes
Why: pairs with txhash_index the way events pairs with events_index.
Unchanged: the default directory on disk ({data_dir}/txhash/raw).
Part of #1176.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renames: - [service.simulation].worker_queue_size -> queue_size Why: next to workers, the worker_ prefix adds nothing. Part of #1176. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renames: - [service.simulation].memory_limit -> max_memory_bytes Why: names the unit, like the max_*_bytes keys in [service]. Part of #1176. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shaptic
force-pushed
the
rpcv2-config-renames
branch
from
November 17, 2026 21:21
4bd3a74 to
aa996f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames 17 rpcv2 config keys before GA freezes them (#1176). Each key's CLI flag follows it, since every flag is its dotted TOML path.
Breaking for rpcv2 beta configs. Old keys fail startup with an unknown-key error. Update configs with the table below.
What changes
[storage]default_data_dirdata_pathcore_*_pathtxhash_rawtxhashesevents/events_index[service.preflight]→[service.simulation]Why the section rename: operators know
simulateTransaction, not "preflight".worker_countworkersworker_queue_sizequeue_sizeworker_prefix added nothingsimulation_memory_limitmax_memory_bytesmax_*_bytes[service.methods.<method>]Applies to
getTransactions,getLedgers,getEvents,queryEvents.max_items_per_responsemax_page_limitpagination.limitdefault_items_per_responsedefault_page_limit[backfill.bsb]→[backfill.download]Why the section rename: "bsb" is SDK jargon.
buffer_sizeprefetch_filesbuffer_bytesprefetch_bytesprefetch_filesnum_workersworkers[ingestion]captive_core_configcore_configcore_prefix, not threecaptive_core_storage_pathcore_storage_pathstellar_core_binary_pathcore_binary_pathcore_http_query_thread_pool_sizecore_http_query_workersNot changing
{data_path}/txhash/rawstays).preflightpackage and its metrics.Review
One commit per rename group. Each commit updates the Go names, error and log messages, tests, sample config, integration-test TOML, design doc, and beta runbook.
Tests
go test ./cmd/stellar-rpc/internal/rpcv2/... ./cmd/stellar-rpc/internal/cli/: 26 packages pass.TestRPCv2ConfigParsesStrictpasses. It checks the sample config against the integration-test TOML.Follow-ups (separate PRs)
[retention].retention_chunks→ a ledger-count window.🤖 Generated with Claude Code